Skip to content

feat(html): generate VJSC skin templates - #2546

Merged
mihar-22 merged 7 commits into
feat/vjsc-framework-skin-packagesfrom
feat/vjsc-html-cdn-templates
Sep 3, 2026
Merged

feat(html): generate VJSC skin templates#2546
mihar-22 merged 7 commits into
feat/vjsc-framework-skin-packagesfrom
feat/vjsc-html-cdn-templates

Conversation

@mihar-22

@mihar-22 mihar-22 commented Aug 29, 2026

Copy link
Copy Markdown
Member

Closes #2493
Parent issue: #2185

Summary

  • generate all eight HTML CSS skins from the canonical prepared registry graph without a second VJSC transform
  • keep short tracked package facades over ignored static templates, exact parent-first registration modules, and complete stylesheets
  • make direct HTML UI subpaths register exactly one component or part while retaining explicit preset composite entries
  • verify package and CDN output retains every template, exact UI/icon closure, complete CSS, and source maps

Verification

  • pnpm -F @videojs/html test
  • pnpm -F @videojs/skins test
  • pnpm exec vp run @videojs/html#build --force
  • pnpm exec vp run @videojs/html#build:cdn --force
  • pnpm -F @videojs/html check:cdn
  • pnpm exec vp run @videojs/skins#validate:shadcn --force
  • pnpm typecheck
  • pnpm lint
  • pnpm check:workspace

Stack


Note

Medium Risk
Touches custom-element registration boundaries, CDN skin bundles, and generated artifacts consumers rely on; regressions could break partial UI imports or CDN players without the new checks catching them.

Overview
Generates all eight HTML default/minimal skins from the canonical VJSC graph into gitignored packages/html/src/internal/skins/ (static template.ts, computed register.ts, and full skin.css). Tracked preset and define/*/skin facades now only wire those outputs—large inline shadow markup and @videojs/skins CSS imports are removed, and @videojs/html no longer depends on @videojs/skins at build time.

Skin entries load an explicit UI closure via generated register modules instead of preset-local ui composites. Direct define/ui/* paths register one custom element each (new granular entries for menu/slider/tooltip parts); composite ui-compounds registration is dropped, with tests updated for skin vs player boundaries.

Build and distribution: @videojs/html build depends on @videojs/skins#generate; Vite treats generated register as side-effectful. check-cdn-skins asserts dev/prod CDN bundles include templates, registrations, complete CSS, source maps, and no VJSC runtime. @videojs/skins adds HTML package generation, Shadcn registry blocks for HTML skins (Tailwind/CSS), and HTML Vite fixture validation alongside React.

Reviewed by Cursor Bugbot for commit d3b2371. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v10-sandbox Ready Ready Preview Sep 3, 2026 6:58pm UTC

Request Review

@netlify

netlify Bot commented Aug 29, 2026

Copy link
Copy Markdown

Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit d3b2371
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/6a99c2e29143bd000765379b
😎 Deploy Preview https://deploy-preview-2546--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Aug 29, 2026

Copy link
Copy Markdown
@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@2546

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@2546

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@2546

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@2546

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@2546

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@2546

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@2546

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@2546

commit: 088235c

@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html

Path Base initial PR initial Initial diff Lazy diff
/video/minimal-skin.css 6.63 kB 8.48 kB +1.85 kB (+27.9%)
/video/skin.css 6.45 kB 8.50 kB +2.05 kB (+31.8%)
/video/minimal-skin 60.80 kB 12.42 kB -48.38 kB (-79.6%) 0 B
/video/minimal-skin2 7.18 kB 9.02 kB +1.84 kB (+25.6%)
/video/skin 61.00 kB 12.49 kB -48.50 kB (-79.5%) 0 B
/video/skin2 7.05 kB 9.13 kB +2.08 kB (+29.6%)
/audio/minimal-skin.css 4.96 kB 5.69 kB +745 B (+14.7%)
/audio/skin.css 4.89 kB 5.54 kB +658 B (+13.1%)
/audio/minimal-skin 46.87 kB 8.55 kB -38.32 kB (-81.8%) 0 B
/audio/minimal-skin2 5.36 kB 6.08 kB +735 B (+13.4%)
/audio/skin 50.69 kB 8.33 kB -42.36 kB (-83.6%) 0 B
/audio/skin2 5.32 kB 5.87 kB +570 B (+10.5%)
/live-video/skin.css 6.45 kB 6.90 kB +454 B (+6.9%)
/live-video/minimal-skin 54.96 kB 9.99 kB -44.96 kB (-81.8%) 0 B
/live-video/skin 57.50 kB 10.13 kB -47.38 kB (-82.4%) 0 B
/live-video/skin2 7.05 kB 7.40 kB +359 B (+5.0%)
/live-audio/minimal-skin.css 4.96 kB 4.33 kB -640 B (-12.6%)
/live-audio/skin.css 4.89 kB 4.25 kB -662 B (-13.2%)
/live-audio/minimal-skin 39.71 kB 6.68 kB -33.03 kB (-83.2%) 0 B
/live-audio/minimal-skin2 5.36 kB 4.62 kB -759 B (-13.8%)
/live-audio/skin 43.34 kB 6.57 kB -36.77 kB (-84.8%) 0 B
/live-audio/skin2 5.32 kB 4.53 kB -804 B (-14.8%)
/ui/alert-dialog 9.44 kB 8.79 kB -667 B (-6.9%) 0 B
/ui/dialog 9.35 kB 8.73 kB -636 B (-6.6%) 0 B
/ui/error-dialog 13.01 kB 12.38 kB -639 B (-4.8%) 0 B
/ui/menu 20.47 kB 18.34 kB -2.13 kB (-10.4%) 0 B
/ui/menu-checkbox-item 1.97 kB new +56.87 kB
/ui/menu-content 7.50 kB new +56.87 kB
/ui/menu-group 2.09 kB new +56.87 kB
/ui/menu-group-label 1.64 kB new
/ui/menu-item 2.29 kB new +56.87 kB
/ui/menu-item-indicator 1.37 kB new +56.87 kB
/ui/menu-radio-group 3.01 kB new +56.87 kB
/ui/menu-radio-item 2.13 kB new +56.87 kB
/ui/menu-separator 1.30 kB new +56.87 kB
/ui/slider 12.12 kB 11.65 kB -477 B (-3.8%) 0 B
/ui/slider-preview 2.01 kB new +56.87 kB
/ui/time-slider 15.04 kB 13.02 kB -2.03 kB (-13.5%) 0 B
/ui/tooltip-label 1.21 kB new
/ui/tooltip-shortcut 1.18 kB new
/ui/volume-slider 12.79 kB 12.31 kB -487 B (-3.7%) 0 B
/video (default) 62.61 kB 21.43 kB -41.19 kB (-65.8%) 0 B
/video (default + hls) 201.59 kB 161.19 kB -40.40 kB (-20.0%) 0 B
/video (minimal) 62.33 kB 21.35 kB -40.98 kB (-65.8%) 0 B
/video (minimal + hls) 201.25 kB 161.13 kB -40.12 kB (-19.9%) 0 B
/audio (default) 52.20 kB 13.66 kB -38.54 kB (-73.8%) 0 B
/audio (minimal) 48.36 kB 13.89 kB -34.47 kB (-71.3%) 0 B
Small changes (11, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
/background/skin 9.77 kB 9.77 kB +6 B (+0.1%) 0 B
/live-video/minimal-skin.css 6.63 kB 6.85 kB +228 B (+3.4%)
/live-video/minimal-skin2 7.18 kB 7.29 kB +104 B (+1.4%)
/ui/controls 8.96 kB 8.77 kB -186 B (-2.0%) 0 B
/ui/seek-indicator 12.69 kB 12.69 kB -9 B (-0.1%) 0 B
/ui/status-indicator 13.03 kB 13.02 kB -10 B (-0.1%) 0 B
/ui/time 10.88 kB 10.80 kB -76 B (-0.7%) 0 B
/ui/time-slider-chapters 9.76 kB 9.64 kB -114 B (-1.1%) 0 B
/ui/tooltip 9.95 kB 9.94 kB -14 B (-0.1%) 0 B
/ui/volume-indicator 13.03 kB 13.01 kB -22 B (-0.2%) 0 B
/background 11.52 kB 11.54 kB +20 B (+0.2%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 21.43 kB 56.87 kB
/video (default + hls) 161.19 kB 56.87 kB
/video (minimal) 21.35 kB 56.87 kB
/video (minimal + hls) 161.13 kB 56.87 kB
/audio (default) 13.66 kB 56.87 kB
/audio (minimal) 13.89 kB 56.87 kB
/background 11.54 kB 56.87 kB
Media (18)
Entry Initial
/media/mux-video 142.40 kB
/media/mux-audio 142.23 kB
/media/background-video 1.16 kB
/media/cloudflare-video 6.28 kB
/media/dash-video 211.61 kB
/media/hls-audio 22.09 kB
/media/hls-background-video 16.80 kB
/media/hls-video 28.04 kB
/media/hlsjs-video 141.22 kB
/media/mux-background-video 16.83 kB
/media/native-hls-video 7.57 kB
/media/shaka-video 199.18 kB
/media/spotify-audio 6.27 kB
/media/tiktok-video 6.33 kB
/media/twitch-video 6.22 kB
/media/vimeo-video 13.05 kB
/media/wistia-video 60.23 kB
/media/youtube-video 6.81 kB
Extensions (2)
Entry Initial
/extensions/google-cast 6.52 kB
/extensions/mux-data 26.94 kB
Players (5)
Entry Initial Lazy
/video/player 9.70 kB 56.87 kB
/audio/player 6.14 kB 56.87 kB
/background/player 4.46 kB 56.87 kB
/live-video/player 9.06 kB 56.87 kB
/live-audio/player 6.15 kB 56.87 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.48 kB
/video/skin.css css 8.50 kB
/video/minimal-skin js 12.42 kB 56.87 kB
/video/minimal-skin2 js 9.02 kB
/video/skin js 12.49 kB 56.87 kB
/video/skin2 js 9.13 kB
/audio/minimal-skin.css css 5.69 kB
/audio/skin.css css 5.54 kB
/audio/minimal-skin js 8.55 kB 56.87 kB
/audio/minimal-skin2 js 6.08 kB
/audio/skin js 8.33 kB 56.87 kB
/audio/skin2 js 5.87 kB
/background/skin.css css 139 B
/background/skin js 9.77 kB 56.87 kB
/background/skin2 js 187 B
/live-video/minimal-skin.css css 6.85 kB
/live-video/skin.css css 6.90 kB
/live-video/minimal-skin js 9.99 kB 56.87 kB
/live-video/minimal-skin2 js 7.29 kB
/live-video/skin js 10.13 kB 56.87 kB
/live-video/skin2 js 7.40 kB
/live-audio/minimal-skin.css css 4.33 kB
/live-audio/skin.css css 4.25 kB
/live-audio/minimal-skin js 6.68 kB 56.87 kB
/live-audio/minimal-skin2 js 4.62 kB
/live-audio/skin js 6.57 kB 56.87 kB
/live-audio/skin2 js 4.53 kB
/global.css css 190 B
/shared.css css 118 B
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.26 kB 56.87 kB
/ui/alert-dialog 8.79 kB 56.87 kB
/ui/audio-track-radio-group 11.38 kB 56.87 kB
/ui/buffering-indicator 8.61 kB 56.87 kB
/ui/captions-button 11.51 kB 56.87 kB
/ui/captions-radio-group 11.46 kB 56.87 kB
/ui/cast-button 11.25 kB 56.87 kB
/ui/container 9.47 kB 56.87 kB
/ui/controls 8.77 kB 56.87 kB
/ui/controls-backdrop 1.69 kB 56.87 kB
/ui/controls-content 1.67 kB 56.87 kB
/ui/dialog 8.73 kB 56.87 kB
/ui/dialog-backdrop 1.70 kB 56.87 kB
/ui/dialog-close 2.06 kB 56.87 kB
/ui/dialog-description 1.69 kB 56.87 kB
/ui/dialog-popup 1.90 kB 56.87 kB
/ui/dialog-title 1.70 kB 56.87 kB
/ui/error-dialog 12.38 kB 56.87 kB
/ui/fullscreen-button 11.27 kB 56.87 kB
/ui/gesture 9.56 kB 56.87 kB
/ui/hotkey 9.97 kB 56.87 kB
/ui/live-button 9.74 kB 56.87 kB
/ui/menu 18.34 kB 56.87 kB
/ui/menu-checkbox-item 1.97 kB 56.87 kB
/ui/menu-content 7.50 kB 56.87 kB
/ui/menu-group 2.09 kB 56.87 kB
/ui/menu-group-label 1.64 kB
/ui/menu-item 2.29 kB 56.87 kB
/ui/menu-item-indicator 1.37 kB 56.87 kB
/ui/menu-radio-group 3.01 kB 56.87 kB
/ui/menu-radio-item 2.13 kB 56.87 kB
/ui/menu-separator 1.30 kB 56.87 kB
/ui/mute-button 11.28 kB 56.87 kB
/ui/pip-button 11.22 kB 56.87 kB
/ui/play-button 11.23 kB 56.87 kB
/ui/playback-rate-button 11.32 kB 56.87 kB
/ui/playback-rate-radio-group 11.37 kB 56.87 kB
/ui/popover 8.56 kB 56.87 kB
/ui/poster 8.67 kB 56.87 kB
/ui/quality-radio-group 11.97 kB 56.87 kB
/ui/seek-button 11.27 kB 56.87 kB
/ui/seek-indicator 12.69 kB 56.87 kB
/ui/seek-indicator-value 1.10 kB
/ui/slider 11.65 kB 56.87 kB
/ui/slider-preview 2.01 kB 56.87 kB
/ui/status-announcer 10.59 kB 56.87 kB
/ui/status-indicator 13.02 kB 56.87 kB
/ui/status-indicator-value 1.10 kB
/ui/thumbnail 9.84 kB 56.87 kB
/ui/time 10.80 kB 56.87 kB
/ui/time-slider 13.02 kB 56.87 kB
/ui/time-slider-chapter-title 8.79 kB 56.87 kB
/ui/time-slider-chapters 9.64 kB 56.87 kB
/ui/title 8.17 kB 56.87 kB
/ui/tooltip 9.94 kB 56.87 kB
/ui/tooltip-label 1.21 kB
/ui/tooltip-shortcut 1.18 kB
/ui/volume-indicator 13.01 kB 56.87 kB
/ui/volume-indicator-fill 1.11 kB
/ui/volume-indicator-value 1.10 kB
/ui/volume-popover 14.72 kB 56.87 kB
/ui/volume-slider 12.31 kB 56.87 kB
⚛️ @videojs/react — no changes
Presets (7)
Entry Initial Lazy
/video (default) 52.57 kB 56.87 kB
/video (default + hls) 190.56 kB 56.87 kB
/video (minimal) 52.62 kB 56.87 kB
/video (minimal + hls) 190.49 kB 56.87 kB
/audio (default) 40.10 kB 56.87 kB
/audio (minimal) 40.25 kB 56.87 kB
/background 581 B 56.87 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 140.61 kB
/media/mux-video/spf 27.39 kB
/media/mux-audio/hls-js 140.55 kB
/media/mux-audio/spf 21.32 kB
/media/background-video 402 B
/media/cloudflare-video 4.34 kB
/media/dash-video 210.29 kB
/media/hls-audio 20.33 kB
/media/hls-background-video 16.46 kB
/media/hls-video 26.34 kB
/media/hlsjs-video 139.44 kB
/media/mux-audio 140.56 kB
/media/mux-background-video 16.45 kB
/media/mux-video 140.54 kB
/media/native-hls-video 5.76 kB
/media/shaka-video 197.52 kB
/media/spotify-audio 4.22 kB
/media/tiktok-video 4.18 kB
/media/twitch-video 4.30 kB
/media/vimeo-video 11.19 kB
/media/wistia-video 60.05 kB
/media/youtube-video 4.86 kB
Extensions (2)
Entry Initial
/extensions/google-cast 5.34 kB
/extensions/mux-data 25.70 kB
Players (5)
Entry Initial Lazy
/video/player 7.56 kB 56.87 kB
/audio/player 4.00 kB 56.87 kB
/background/player 2.27 kB 56.87 kB
/live-video/player 6.96 kB 56.87 kB
/live-audio/player 3.99 kB 56.87 kB
Skins (18)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.34 kB
/video/skin.css css 8.36 kB
/video/minimal-skin js 52.58 kB 56.87 kB
/video/skin js 52.44 kB 56.87 kB
/audio/minimal-skin.css css 5.62 kB
/audio/skin.css css 5.47 kB
/audio/minimal-skin js 40.13 kB 56.87 kB
/audio/skin js 40.04 kB 56.87 kB
/background/skin.css css 90 B
/background/skin js 277 B
/live-video/minimal-skin.css css 6.70 kB
/live-video/skin.css css 6.77 kB
/live-video/minimal-skin js 43.78 kB 56.87 kB
/live-video/skin js 43.80 kB 56.87 kB
/live-audio/minimal-skin.css css 4.23 kB
/live-audio/skin.css css 4.12 kB
/live-audio/minimal-skin js 30.83 kB 56.87 kB
/live-audio/skin js 30.82 kB 56.87 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 10.43 kB 56.87 kB
/ui/alert-dialog 4.71 kB 56.87 kB
/ui/audio-track 7.93 kB 56.87 kB
/ui/audio-track-radio-group 9.45 kB 56.87 kB
/ui/buffering-indicator 7.77 kB 56.87 kB
/ui/captions-button 10.40 kB 56.87 kB
/ui/captions-radio-group 9.57 kB 56.87 kB
/ui/cast-button 10.40 kB 56.87 kB
/ui/controls 7.68 kB 56.87 kB
/ui/dialog 4.73 kB 56.87 kB
/ui/error-dialog 11.77 kB 56.87 kB
/ui/fullscreen-button 10.36 kB 56.87 kB
/ui/gesture 7.99 kB 56.87 kB
/ui/hotkey 8.38 kB 56.87 kB
/ui/live-button 8.76 kB 56.87 kB
/ui/menu 19.30 kB 56.87 kB
/ui/mute-button 10.41 kB 56.87 kB
/ui/pip-button 10.36 kB 56.87 kB
/ui/play-button 10.35 kB 56.87 kB
/ui/playback-rate 7.99 kB 56.87 kB
/ui/playback-rate-button 10.35 kB 56.87 kB
/ui/playback-rate-radio-group 9.50 kB 56.87 kB
/ui/popover 8.13 kB 56.87 kB
/ui/poster 7.54 kB 56.87 kB
/ui/quality 8.42 kB 56.87 kB
/ui/quality-radio-group 9.92 kB 56.87 kB
/ui/seek-button 10.38 kB 56.87 kB
/ui/seek-indicator 11.95 kB 56.87 kB
/ui/slider 12.73 kB 56.87 kB
/ui/status-announcer 10.06 kB 56.87 kB
/ui/status-indicator 12.26 kB 56.87 kB
/ui/thumbnail 8.71 kB 56.87 kB
/ui/time 9.74 kB 56.87 kB
/ui/time-slider 14.15 kB 56.87 kB
/ui/title 7.24 kB 56.87 kB
/ui/tooltip 8.90 kB 56.87 kB
/ui/volume-indicator 12.32 kB 56.87 kB
/ui/volume-popover 14.17 kB 56.87 kB
/ui/volume-slider 12.11 kB 56.87 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 13.15 kB
/dom 22.42 kB 56.87 kB
/vjsc 1.82 kB
/i18n 3.23 kB 56.87 kB
/i18n/locales/all 34.97 kB
/i18n/locales/ar 1.22 kB
/i18n/locales/az 1.09 kB
/i18n/locales/bg 1.29 kB
/i18n/locales/bn 1.23 kB
/i18n/locales/bs 1.00 kB
/i18n/locales/ca 1.07 kB
/i18n/locales/cs 1.07 kB
/i18n/locales/cy 1.02 kB
/i18n/locales/da 1006 B
/i18n/locales/de 1.09 kB
/i18n/locales/el 1.49 kB
/i18n/locales/en 785 B
/i18n/locales/es 1018 B
/i18n/locales/et 1.05 kB
/i18n/locales/eu 1.03 kB
/i18n/locales/fa 1.22 kB
/i18n/locales/fi 1.04 kB
/i18n/locales/fr 1.07 kB
/i18n/locales/gd 1.10 kB
/i18n/locales/gl 1022 B
/i18n/locales/he 1.14 kB
/i18n/locales/hi 1.30 kB
/i18n/locales/hr 1.02 kB
/i18n/locales/hu 1.10 kB
/i18n/locales/id 919 B
/i18n/locales/it 1.01 kB
/i18n/locales/ja 1.18 kB
/i18n/locales/ko 1.14 kB
/i18n/locales/lt 1.02 kB
/i18n/locales/lv 1.09 kB
/i18n/locales/mr 1.30 kB
/i18n/locales/nb 987 B
/i18n/locales/ne 1.29 kB
/i18n/locales/nl 1.00 kB
/i18n/locales/nn 987 B
/i18n/locales/oc 1.08 kB
/i18n/locales/pl 1.14 kB
/i18n/locales/pt 1.03 kB
/i18n/locales/pt-BR 1.03 kB
/i18n/locales/pt-PT 1.01 kB
/i18n/locales/ro 1.07 kB
/i18n/locales/ru 1.40 kB
/i18n/locales/sk 1.10 kB
/i18n/locales/sl 1.04 kB
/i18n/locales/sr 1.07 kB
/i18n/locales/sv 1.01 kB
/i18n/locales/te 1.32 kB
/i18n/locales/th 1.29 kB
/i18n/locales/tr 1.08 kB
/i18n/locales/uk 1.41 kB
/i18n/locales/vi 1.11 kB
/i18n/locales/zh 1.02 kB
/i18n/locales/zh-CN 1.02 kB
/i18n/locales/zh-TW 1.02 kB
/i18n/text/airplay 101 B
/i18n/text/buttons 137 B
/i18n/text/captions 93 B
/i18n/text/cast 114 B
/i18n/text/common 90 B
/i18n/text/container 75 B
/i18n/text/errors 285 B
/i18n/text/fullscreen 98 B
/i18n/text/live 126 B
/i18n/text/menu 249 B
/i18n/text/pip 101 B
/i18n/text/playback 80 B
/i18n/text/seek 105 B
/i18n/text/slider 65 B
/i18n/text/status 222 B
/i18n/text/time 280 B
/i18n/text/volume 133 B
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 365 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.02 kB
/events 320 B
/function 386 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 976 B
/number 199 B

📦 @videojs/media

Path Base initial PR initial Initial diff Lazy diff
/dom/dash 209.83 kB 3.28 kB -206.54 kB (-98.4%)
/dom/wistia 60.09 kB 1.89 kB -58.20 kB (-96.9%)
Entries (23)
Entry Initial
. 1.07 kB
/dom 121 B
/dom/dash 3.28 kB
/dom/wistia 1.89 kB
/dom/audio-host 1.10 kB
/dom/cloudflare 3.69 kB
/dom/custom-media-element 2.13 kB
/dom/dash 209.83 kB
/dom/google-cast 4.06 kB
/dom/hls-js 139.16 kB
/dom/media-host 1.20 kB
/dom/media-played-ranges 576 B
/dom/mux 162.88 kB
/dom/native-hls 5.25 kB
/dom/shaka 197.02 kB
/dom/spotify 3.58 kB
/dom/tiktok 3.57 kB
/dom/twitch 3.62 kB
/dom/video-host 1.39 kB
/dom/vimeo 10.62 kB
/dom/wistia 60.09 kB
/dom/youtube 4.25 kB
/media-tracks 2.05 kB
📦 @videojs/spf — no changes
Entries (10)
Entry Initial
. 4.55 kB
/dom 6.60 kB
/hls 22.06 kB
/media-tracks 504 B
/hls-background-video 15.89 kB
/hls-audio 19.82 kB
/hls-video 25.85 kB
/mux-audio 20.76 kB
/mux-background-video 15.89 kB
/mux-video 26.67 kB

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@mihar-22
mihar-22 force-pushed the feat/vjsc-html-cdn-templates branch from 088235c to 323930c Compare September 3, 2026 18:52
@mihar-22
mihar-22 force-pushed the feat/vjsc-html-cdn-templates branch from 323930c to 6b5ec1d Compare September 3, 2026 18:53
@mihar-22
mihar-22 force-pushed the feat/vjsc-html-cdn-templates branch from 6b5ec1d to 4a768ae Compare September 3, 2026 18:53
@mihar-22
mihar-22 force-pushed the feat/vjsc-html-cdn-templates branch from 4a768ae to 3a1fac4 Compare September 3, 2026 18:54
@mihar-22
mihar-22 force-pushed the feat/vjsc-html-cdn-templates branch from 3a1fac4 to d3b2371 Compare September 3, 2026 18:56
@mihar-22
mihar-22 merged commit 70a1230 into main Sep 3, 2026
13 of 24 checks passed
@mihar-22
mihar-22 deleted the feat/vjsc-html-cdn-templates branch September 3, 2026 18:59

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d3b2371. Configure here.

},
"scripts": {
"check:cdn": "node --import tsx ./scripts/check-cdn-self-contained.ts",
"check:cdn": "node --import tsx ./scripts/check-cdn-self-contained.ts && node --import tsx ./scripts/check-cdn-skins.ts",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skin registers omitted from sideEffects

High Severity

Generated skin register modules are side-effect-only (bare define/ui/* imports plus registerIcons()), but package.json sideEffects still lists only define/**, i18n, and icon element paths. The Vite pack config now treats /internal/skins/*/register as side-effectful so this package's own build keeps them; consumer bundlers that honor sideEffects (webpack, Vite/Rollup production) do not. Importing a skin or preset can drop the register graph, leave template tags as plain HTMLElement, and throw on methods such as setSyncedText.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d3b2371. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Generate VJSC HTML CDN Skin Templates

2 participants