feat(skin): generate framework skins from registry - #2545
Merged
mihar-22 merged 5 commits intoSep 3, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 29, 2026
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
commit: |
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
August 29, 2026 19:18
e553225 to
8b2a706
Compare
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Extensions (2)
Players (5)
Skins (29)
UI Components (50)
⚛️ @videojs/react
Small changes (1, ≤ 300 B)
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/media
Entries (23)
📦 @videojs/spf — no changesEntries (10)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
August 29, 2026 19:47
9f75c68 to
f2cebbf
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
August 29, 2026 20:08
06b6084 to
bbf2fb0
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
August 29, 2026 20:14
bbf2fb0 to
d154dfd
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
August 29, 2026 20:38
d154dfd to
404faad
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
August 29, 2026 21:28
404faad to
cb0092d
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
August 29, 2026 21:42
cb0092d to
57897cd
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
August 31, 2026 01:24
57897cd to
51d214b
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
August 31, 2026 02:39
51d214b to
c5f3e65
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
September 3, 2026 00:28
c5f3e65 to
5b7ca50
Compare
mihar-22
marked this pull request as ready for review
September 3, 2026 06:05
decepulis
approved these changes
Sep 3, 2026
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
September 3, 2026 18:52
5b7ca50 to
e9d1bf8
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
September 3, 2026 18:53
e9d1bf8 to
ee6a533
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
September 3, 2026 18:53
ee6a533 to
a7b596c
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
September 3, 2026 18:54
a7b596c to
6e4d571
Compare
mihar-22
force-pushed
the
feat/vjsc-framework-skin-packages
branch
from
September 3, 2026 18:56
6e4d571 to
8e8f827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pnpm build:packagespnpm typecheckpnpm lintpnpm check:workspaceCloses #2492
Stack
Note
Medium Risk
Large-scale swap of tracked player UI implementations for generated output; public API is preserved via wrappers but any generator or graph drift could change runtime DOM/CSS across all presets.
Overview
React preset skins (
skin.tsx,minimal-skin.tsx, and matching CSS) are no longer maintained by hand. They are generated from the canonical VJSC component graph during@videojs/skins#generate(renamed fromprepare:shadcn) and written underpackages/react/src/internal/skins/plus thin public wrappers that keep the same export names and props (renderPoster, etc.). Those paths are gitignored; Background remains authored underpackages/skins/framework/react/and is copied in by the generator.A new
skin-primitivesmodule gives generated skins an acyclic import surface into React UI primitives. React build, roottypecheck:workspace, andprepare:devnow depend on@videojs/skins#generate. React no longer bundles@videojs/skinsat pack time; CSS is copied from packagesrcpresets. Preset barrels drop Tailwind skin re-exports.VJSC gains shared graph helpers (module collection, import rewriting, merged stylesheet emission) used by both the Shadcn registry and the new framework generator.
cnacceptsfalse/null; site ejected-skins inlining follows forwarded exports throughskin-primitives. Tests were updated for generated markup class names and decoupled from@videojs/skinsTailwind tokens.Reviewed by Cursor Bugbot for commit 8e8f827. Bugbot is set up for automated code reviews on this repo. Configure here.