Skip to content

Fix forkless save remaining time estimate #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimB123 merged 1 commit into from
Aug 20, 2026
+7 −6
Merged

Fix forkless save remaining time estimate #4468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/forkless.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,12 +372,13 @@ sds forkless_catInfo(sds info) {
current_item_millis = status.current_item_ms;

if (status.dbentries_processed > 0) {
long long total_keys = 0;
for (int i = 0; i < server.dbnum; i++) {
total_keys += server.db[i] ? dbSize(server.db[i]) : 0;
}
estimated_seconds_remaining = (total_keys - status.dbentries_processed) *
status.runtime_ms / status.dbentries_processed / 1000;
long long total_keys =
(long long)atomic_load_explicit(&server.stat_current_save_keys_total, memory_order_relaxed);
/* The ETA is best effort. Clamp at 0 since dbentries_processed
* can exceed total_keys (e.g. a full sync may process more than
* the start-time key count). */
long long remaining = max(total_keys - (long long)status.dbentries_processed, 0);
estimated_seconds_remaining = remaining * status.runtime_ms / status.dbentries_processed / 1000;
}
}
}
Expand Down
Loading