Fix forkless save remaining time estimate

[nitaicaro]

forkless_estimated_seconds_remaining sampled the live key count now, but compared it against dbentries_processed, which counts progress through the point-in-time snapshot taken when the save started. If keys were deleted during the save, the live count could drop below dbentries_processed and the estimate went negative.

Use server.stat_current_save_keys_total, the key count captured when the save started, so both sides of the subtraction share the same baseline and the estimate stays non-negative.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5eaba11a-4f8b-4701-b3a7-9de4fad1a6a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[valkey-review-bot]

The ETA now uses a stable baseline, but that global can be reset by an unrelated fork while the forkless iterator is still active.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.40%. Comparing base (0a50265) to head (4487472).
⚠️ Report is 5 commits behind head on forkless.

Additional details and impacted files

@@             Coverage Diff              @@
##           forkless    #4468      +/-   ##
============================================
- Coverage     79.69%   79.40%   -0.29%     
============================================
  Files           175      175              
  Lines         94841    93222    -1619     
============================================
- Hits          75581    74024    -1557     
+ Misses        19260    19198      -62     

Files with missing lines	Coverage Δ
src/forkless.c	84.86% <100.00%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.