You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have no objections, as long as they do not become a subset of geolocation-!cn.
This way, users can explicitly choose whether or not to route this traffic directly via Chinese IPs based on their own needs, rather than having it sent to the proxy by default.
Literally speaking, these domains could indeed be included under the semantics of geolocation-!cn, but we must take community habits into account.
Countless tutorials, documents, user perceptions, and GUI clients default to routing geolocation-!cn traffic through a proxy.
For these category-cn-expat domains, forcing them to either route directly or go through a proxy is inappropriate. The best approach is to leave the choice to the users.
Perhaps the name of the category could be reconsidered, such as cn-oversea.
However, this is not particularly important, just decide according to your preference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are part of Chinese entities but exclusively serving for non-cn area.
After #3198 moved them out from
category-xxx-cn/geolocation-cn, the new list can be a replacement of formergeosite:geolocation-cn@!cn.This list is NOT included in
geolocation-cn,cnorgeolocation-!cn, as we did not reach a consensus in #3265.If there's no objection, I'll merge this in a month.