Repository navigation
Conversation
|
What are we doing here bro, the
Adding domains of China mainland-based companies that serve non-cn area into this list doesn't make sense. These domains still belong to Chinese companies, not foreign ones — this contradicts the list's own description and makes the categorization misleading. This probably goes back to how the project categorized things in the first place — some lists may have been poorly named from the start. But that's not a reason to make it worse by adding more mismatched entries. don't do this bro |
Well, I thought these domains are used by their foreign subsidiary which may considered as non-cn companies. I can add them directly in Beyond this naming/categorization detail, actually, I am more concerned about whether this change is reasonable/necessary. I think removing TBH, I don't like the idea to add all Do you have any suggestions about that? Feel free to share your ideas. |
They are part of Chinese entities but **exclusively** serving for non-cn area This is a continuation of #3198
|
How about handling it this way? @nekolsd |
|
Under no circumstances should Chinese entities be included in |
Could you explain this? I don't quite understand. In my understanding, we mark one domain with Actually, some downstream projects, Loyalsoldier/MetacubeX/SagerNet, are even more aggressive. They already added Currently, this repo has moved |
|
Usually, people consider Once overseas businesses of Chinese entities are merged into |
If anyone does not want to proxy all I think we should do things right, not cater to existing improper perceptions/expectations. |
|
This will trigger large-scale configuration changes downstream. Because some people want Chinese entities to connect directly via Chinese IPs, even for overseas services, especially for things like online banking. Placing |
So true. If it ain't broke, don't fix it |
I'd like to add a few points to this discussion: 1. If the goal is truly to route based on where the server is actually located, that requires IP-level classification, not domain-level classification If what users actually want is "route based on the server's real geographic location," the most rigorous approach would be to resolve all domains to IPs first, then decide routing based on the IP's actual region — rather than giving a domain a fixed regional label. A static, domain-level classification is at best an approximation of "which region this entity tends to serve," not a precise reflection of "where this specific connection is actually going right now." 2. On this statement:
If we follow this standard strictly, two practical problems arise:
So my view is: using "the region an IP resolves to" to help users decide whether a domain should be proxied is not something That said, this approach isn't without trade-offs. It can't satisfy two legitimate user needs:
Even so, I believe we should lean toward the more conservative approach, for three reasons:
|
Yes. And I don't think this PR breaks that.
The "original expectation" is not clear. Different users may have different expectations. Entities are different from categories. A list of a certain category/geolocation does not stand for one or multiple entities. In this PR, lists of entities are not changed at all. Only
Users can still achieve the "route by entity as a whole" intent, just add an explicit routing rule in their configuration before the
The new finer split may be the exact intents of some other users. Both intents are not wrong. Nobody is forced to route any traffic against their intents. If this PR violates some users' intents, then I would say the original situation violates other users' intents. The reason does not make sense. Once again, the question should be "Should we add non-cn domains of China entities into lists of A classic example is tiktok and bytedance. If you visit tiktok directly in China, then it's not available at all. Another example is foreign games bought by tencent, the game may still be unavailable after the legal ownership changes. If
The entity-based classification in category lists is somehow caused by the limit of old For downstream projects:
The literal sober meaning of
Yes. This would change some default behavior. So we are disscussing here.
Services with tricky proxy detection should be handled with additional attention. Since you don't want For
So I don't this is a problem we can avoid. |
|
I'll close this in favor of #4220. Feel free to share your ideas. |
They are part of Chinese entities but exclusively serving for non-cn area
As #3198 moved them out from
category-xxx-cn/geolocation-cn, this adds them intocategory-xxx-!cn/geolocation-!cnIf there's no objection, I'll merge this in a week