Skip to content

Fix a bug where add_plugin uses a pointer to a freed string's data. #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mardigontoler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a bug where add_plugin uses a pointer to a freed string's data. #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/fmod_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ Ref<FmodBank> FmodCache::get_bank(const String& bankPath) {
uint32_t FmodCache::add_plugin(const String& p_plugin_path, uint32_t p_priority) {
uint32_t handle;
#if defined(ANDROID_ENABLED) && !defined(TOOLS_ENABLED)
const char* plugin_path = p_plugin_path.utf8().get_data();
const CharString plugin_path_utf8 = p_plugin_path.utf8();
#else
const char* plugin_path = ProjectSettings::get_singleton()->globalize_path(p_plugin_path).utf8().get_data();
const CharString plugin_path_utf8 = ProjectSettings::get_singleton()->globalize_path(p_plugin_path).utf8();
#endif
ERROR_CHECK(core_system->loadPlugin(plugin_path, &handle, p_priority));
ERROR_CHECK(core_system->loadPlugin(plugin_path_utf8.get_data(), &handle, p_priority));
plugin_handles.append(handle);
return handle;
}
Expand Down