Fix a bug where add_plugin uses a pointer to a freed string's data. - #443
Open
mardigontoler wants to merge 1 commit into
Open
Fix a bug where add_plugin uses a pointer to a freed string's data.#443mardigontoler wants to merge 1 commit into
mardigontoler wants to merge 1 commit into
Conversation
mardigontoler
requested a deployment
to
external-pr
August 15, 2026 03:19 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
mardigontoler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extension was failing to load plugins on macos. I found that in add_plugin, the result of
p_plugin_path.utf8().get_data()was being stored in a variable. However, because.utf8allocates a new string for itself but was only being used a temporary value, it's de-allocated at the end of that expression, and the resulting pointer is dangling.This PR stores the
CharStringreturned from.utf8()as a local variable, so the memory is still valid when we use the result ofget_data().