Skip to content

Add SPH correction consistency study - #1286

Draft
svchb wants to merge 8 commits into
trixi-framework:mainfrom
svchb:validation/correction-consistency-study
Draft

Add SPH correction consistency study#1286
svchb wants to merge 8 commits into
trixi-framework:mainfrom
svchb:validation/correction-consistency-study

Conversation

@svchb

@svchb svchb commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • document consistency degrees separately from full-discretization convergence orders
  • add a manufactured study for interpolation, density, gradient, and pressure operators
  • report truncated-boundary and symmetric-interior behavior separately
  • cover every supported correction and pressure pairing
  • write reproducible Markdown and CSV output
  • keep reduced-resolution regression assertions in a dedicated validation test file

Stack

Depends on #1285. This PR targets main and temporarily includes the complete preceding stack.

Review-only diff: svchb/TrixiParticles.jlOpen@feature/independent-correction-configuration...validation/correction-consistency-study

Isolated layer: 5 files, 780 additions.

Verification

  • julia --project=. validation/corrections/convergence.jl passed
  • complete unit suite passed
  • JuliaFormatter and git diff --check passed

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.81314% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.64%. Comparing base (a720b1d) to head (3fb26bb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/examples/gpu.jl 0.00% 23 Missing ⚠️
src/general/corrections.jl 89.28% 6 Missing ⚠️
src/io/io.jl 0.00% 5 Missing ⚠️
src/schemes/structure/rigid_body/system.jl 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   90.39%   90.64%   +0.25%     
==========================================
  Files         138      147       +9     
  Lines       11322    11772     +450     
==========================================
+ Hits        10234    10671     +437     
- Misses       1088     1101      +13     
Flag Coverage Δ
total 90.65% <92.81%> (+0.25%) ⬆️
unit 79.40% <92.81%> (+1.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb
svchb force-pushed the validation/correction-consistency-study branch from 485b998 to 3fb26bb Compare August 16, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant