Make SPH correction configuration consistent - #1281
Closed
svchb wants to merge 2 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
+ Coverage 90.39% 90.46% +0.07%
==========================================
Files 138 139 +1
Lines 11322 11523 +201
==========================================
+ Hits 10234 10424 +190
- Misses 1088 1099 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
This draft has been split into three smaller review layers:
The original branch remains available for reference, but this umbrella PR is superseded by those drafts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CorrectionConfigurationso density and gradient corrections can be selected independently.Validation
validation/corrections/convergence.jlcovers corrected density and gradient operators, boundary behavior, and pressure consistency.git diff --checkpasses.Dependencies
This PR is independent of the generalized surface-method PR.