Editorial: avoid some unions with ~unused~ - #3922
Merged
Merged
Conversation
bakkot
marked this pull request as ready for review
July 24, 2026 02:58
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3922 and as multiple pages at https://tc39.es/ecma262/pr/3922/multipage . |
linusg
approved these changes
Jul 24, 2026
nicolo-ribaudo
added
the
ready to merge
michaelficarra
approved these changes
Jul 24, 2026
Collaborator
I think we could address it after #3896 lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #3921 (comment).
There is still an instance in RunSuspendedContext. But it's a little buggy currently (see https://matrixlogs.bakkot.com/TC39_Editors/2026-06-26) and also we have multiple changes in flight (#3896, #2962) so I'm not touching it right now. We can address it either as part of those or after they land.
I ran tc39/ecmarkup#714 against this and got no errors, which is not perfect assurance, but is some.
I will still want to do #3921 after this lands.