Editorial: assert that MethodDefinitionEvaluation on object properties does not produce a PrivateElement - #3921
Merged
Conversation
bakkot
marked this pull request as ready for review
July 23, 2026 21:34
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3921 and as multiple pages at https://tc39.es/ecma262/pr/3921/multipage . |
nicolo-ribaudo
approved these changes
Jul 24, 2026
bakkot
force-pushed
the
assert-not-object-private-name
branch
from
August 6, 2026 03:05
208d8f9 to
57ee24b
Compare
Member
Author
|
Rebased, @michaelficarra PTAL |
michaelficarra
approved these changes
Aug 6, 2026
michaelficarra
added
the
ready to merge
…s does not produce a PrivateElement (tc39#3921)
ljharb
force-pushed
the
assert-not-object-private-name
branch
from
August 6, 2026 05:24
57ee24b to
7cb06a7
Compare
Jack-Works
added a commit
to engine262/engine262
that referenced
this pull request
Aug 10, 2026
…s does not produce a PrivateElement tc39/ecma262#3921
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also assert that the switch over the return value of MethodDefinitionEvaluation in ClassDefinitionEvaluation is exhaustive.
It's kinda weird to useDone in #3922.~unused~for this; I'd feel better about~empty~. But whatever, that can be a follow-up.There's a callsite of DefineMethodProperty in ClassDefinitionEvaluation that could use this assert as well, but I think it's less needed, so I left it out: