Repository navigation
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd3056ac98
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| git fetch --tags origin "${TAG}" | ||
| git checkout "${TAG}" |
There was a problem hiding this comment.
Bind the reproduction workflow to the documented artifacts
The workflow resolves TAG to whatever v0.9.0 currently points at, but never asserts HEAD is the documented dcbf... commit or checks either downloaded blob against the SHA-256 values in the new table. If the tag is force-moved and the corresponding release assets are replaced, both source-vs-release diffs can succeed against the altered release, so this procedure no longer verifies the artifacts that Proposal0026 documents. Check the checkout commit and run SHA-256 verification immediately after each download.
Useful? React with 👍 / 👎.
🐋 DeepSeek Code Review🔴 Critical IssuesNone. 🟡 Warnings
🔵 Suggestions
🟢 What Looks Good
Automatically triggered on PR update • model: |
4559c11
into
claude/proposal0024-basefee-sharing-100


Summary
The stacked base already contains
a3d4cdc1(chore(protocol): drop the unused raiko2 v0.9.0-rc1 constants), so this PR does not duplicate that removal. This is documentation-only and does not change Proposal0026 calldata or runtime behavior.Verification
pnpm exec prettier --check packages/protocol/script/layer1/proposals/Proposal0026.mdFOUNDRY_PROFILE=layer1 forge test --match-contract Proposal0026Test -vv(6 passed)FOUNDRY_PROFILE=layer1 forge buildP=0026 pnpm proposalL1_FORK_URL=https://eth.drpc.org FOUNDRY_PROFILE=layer1 forge test --match-contract Proposal0026ForkTest -vv(2 passed)bash -nnextInstanceId, and instance 2 providersThe expensive full guest and SGX image rebuilds were not rerun for this documentation follow-up; the documented commands were checked against the final v0.9.0 release instructions and the published artifacts, registry objects, live state, unit tests, and fork rehearsal were verified directly.
Note
Low Risk
Markdown-only updates to the Proposal0026 runbook; no contract, script, or governance calldata changes.
Overview
Proposal0026 runbook gains end-to-end raiko2 v0.9.0 artifact verification: links to the release page, a table of release assets with SHA-256 hashes, and copy-paste steps to reproduce ZK guest digests and TEE attestation metadata from source (including stripping
mr_signerfor local SGX builds), plusdocker buildx imagetools inspectfor the four published image tags.The Verification section adds live mainnet preflight checks (legacy trust on, v0.9.0 identifiers off, SGX
nextInstanceIdand instance2) and splits inbox/fork rehearsal under its own heading. Documented Bash blocks now quoteL1_RPC='<l1 rpc>'so they passbash -n.Documentation only; no proposal calldata or on-chain behavior changes.
Reviewed by Cursor Bugbot for commit bd3056a. Bugbot is set up for automated code reviews on this repo. Configure here.