Skip to content

Honor catalog video aspect-ratio defaults - #1885

Open
matthewpenkala wants to merge 2 commits into
storytold:mainfrom
matthewpenkala:contrib/honor-video-default-aspect-ratio
Open

Honor catalog video aspect-ratio defaults#1885
matthewpenkala wants to merge 2 commits into
storytold:mainfrom
matthewpenkala:contrib/honor-video-default-aspect-ratio

Conversation

@matthewpenkala

Copy link
Copy Markdown

Summary

  • Hydrate a video model's catalog-declared default aspect ratio independently from option order.
  • Preserve the current user choice while it remains supported.
  • Resolve an invalid or missing choice to the declared default, then retain the first-option fallback for legacy catalogs.
  • Use the same resolver for the control, generation request, and cost estimate.

Why

The first advertised option is not necessarily the model's canonical default. Different consumers could therefore display, estimate, and submit different aspect ratios after model hydration or a model switch.

Validation

  • Focused resolver and listing-loader suite: 6/6 passed.
  • Declared defaults, valid sticky choices, invalid future values, option-order preservation, and legacy fallback are covered.
  • The new spec is formatter-clean; git diff --check and contribution-scope scans pass.

Integration note

This PR and #1884 both touch useVideoCostEstimate.ts. The behaviors are complementary; if the estimate-lifecycle PR lands first, this branch will be rebased so the shared freshness guarantees remain intact.

Origin and scope

This change was isolated from a broader downstream integration and reduced to a generic, self-contained upstream contribution. Private deployment/release-specific material and artifacts are intentionally excluded.

@netlify

netlify Bot commented Aug 11, 2026

Copy link
Copy Markdown

👷 Deploy request for artcraft-webapp pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 30a0d09

@netlify

netlify Bot commented Aug 11, 2026

Copy link
Copy Markdown

Deploy Preview for artcraft-dashboard ready!

Name Link
🔨 Latest commit 30a0d09
🔍 Latest deploy log https://app.netlify.com/projects/artcraft-dashboard/deploys/6a8381b7221e930008ad6911
😎 Deploy Preview https://deploy-preview-1885--artcraft-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Aug 11, 2026

Copy link
Copy Markdown

Deploy Preview for storyteller-docs ready!

Name Link
🔨 Latest commit 30a0d09
🔍 Latest deploy log https://app.netlify.com/projects/storyteller-docs/deploys/6a8381b782810a0008b6cfde
😎 Deploy Preview https://deploy-preview-1885--storyteller-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant