Honor video duration ranges and sparse duration options - #1892
Draft
matthewpenkala wants to merge 2 commits into
Draft
Honor video duration ranges and sparse duration options#1892matthewpenkala wants to merge 2 commits into
matthewpenkala wants to merge 2 commits into
Conversation
👷 Deploy request for artcraft-webapp pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for storyteller-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for artcraft-dashboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[5, 10]cannot emit unsupported intermediate values.Why
Video listings can describe either continuous ranges or discrete supported durations. The existing prompt flow treated those contracts inconsistently, which could expose unsupported selections, estimate one duration while sending another, or apply an image cap to hidden media omitted from the request.
This centralizes the behavior without model-specific branching.
Validation
Focused coverage exercises:
git diff --checkand contribution-scope scans pass.Integration status
This is the first layer of a deliberately serialized reference-media series. It also composes with the estimate-lifecycle work in #1884 and the aspect-default work in #1885. The PR is opened as a draft so those smaller shared-consumer changes can land first; this branch will then be rebased onto current
main, revalidated, and marked ready without replacing either behavior.Related work
#1408 and #1186 also touch
PromptBoxVideo.tsx, but address multishot and batch generation behavior rather than generic model duration contracts.Origin and scope
This change was isolated from a broader downstream integration and reduced to a generic, self-contained upstream contribution. Private deployment/release-specific material and artifacts are intentionally excluded.