feat: add app_level_token_rotation_enabled setting to app manifest - #682
Merged
Merged
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
3 of 5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
- Coverage 78.23% 78.22% -0.01%
==========================================
Files 239 239
Lines 18149 18149
==========================================
- Hits 14198 14197 -1
- Misses 3951 3952 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zimeg
marked this pull request as ready for review
October 1, 2026 21:50
mwbrooks
approved these changes
Oct 2, 2026
mwbrooks
left a comment
Member
There was a problem hiding this comment.
✅ Thanks for getting ahead of this one! 🙇🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request adds the
settings.app_level_token_rotation_enabledboolean field to theAppSettingsmanifest type.xoxe.xapp-) that expire after 12 hours and come with a single-use refresh tokentoken_rotation_enabledPreview
N/A
Testing
Notes
Follows the existing
*bool+omitemptypattern used bytoken_rotation_enabledandis_mcp_enabled(#513).gofmtrealigned theAppSettingsstruct tags since the new field name is the longest.Companion schema change: slackapi/manifest-schema#90.
Requirements
🤖 Generated with Claude Code