Skip to content

feat: add app_level_token_rotation_enabled setting to the manifest schema - #90

Merged
zimeg merged 2 commits into
mainfrom
app-level-token-rotation
Oct 6, 2026
Merged

zimeg merged 2 commits into
mainfrom
app-level-token-rotation

Conversation

@zimeg

@zimeg zimeg commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request adds the settings.app_level_token_rotation_enabled boolean to the v1 and v2 manifest schemas.

Testing

  • Validate tests/manifests/v{1,2}/manifest.valid.json with "app_level_token_rotation_enabled": true added to settings against schemas/manifest.schema.{1,2}.0.0.json directly and confirm it passes
  • Set the field to a non-boolean (e.g. "yes") and confirm validation fails

Category

  • manifest.schema.json edit
  • /schema and/or its core components
  • Others

Requirements

  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

🤖 Generated with Claude Code

…hema

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg zimeg added enhancement New feature or request semver:minor labels Oct 1, 2026
@zimeg zimeg self-assigned this Oct 1, 2026
@zimeg
zimeg marked this pull request as ready for review October 1, 2026 21:50
@zimeg

zimeg commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

@WilliamBergamin Thanks for a kind review! Let's bring this out with an upcoming release so I'll merge this now.

@zimeg
zimeg merged commit 7ec398e into main Oct 6, 2026
4 checks passed
@zimeg
zimeg deleted the app-level-token-rotation branch October 6, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants