Repository navigation
feat: add app_level_token_rotation_enabled setting to the manifest schema - #90
Merged
Merged
Conversation
…hema Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
WilliamBergamin
approved these changes
Oct 6, 2026
Member
Author
|
@WilliamBergamin Thanks for a kind review! Let's bring this out with an upcoming release so I'll merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the
settings.app_level_token_rotation_enabledboolean to the v1 and v2 manifest schemas.xoxe.xapp-) with this settingadditionalProperties: false, so manifests that include this field currently fail validation in editorsallowed_ip_address_rangesv0.5.0schemas through the root router, matching feat: add code_channels feature to the manifest schema #86Testing
tests/manifests/v{1,2}/manifest.valid.jsonwith"app_level_token_rotation_enabled": trueadded tosettingsagainstschemas/manifest.schema.{1,2}.0.0.jsondirectly and confirm it passes"yes") and confirm validation failsCategory
manifest.schema.jsonedit/schemaand/or its core componentsRequirements
./scripts/install_all_and_run_tests.shafter making the changes.🤖 Generated with Claude Code