Skip to content

Skip edit-previous shortcut during IME composition #7904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayubun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip edit-previous shortcut during IME composition #7904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ts/hooks/useKeyboardShortcuts.dom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,13 @@ export function useEditLastMessageSent(
return false;
}

// Ignore keys that are part of an active IME composition (e.g. when
// navigating the Japanese transliteration candidate menu with ArrowUp).
// keyCode 229 covers Safari/older browsers that don't set `isComposing`.
if (ev.isComposing || ev.keyCode === 229) {
return false;
}

const key = KeyboardLayout.lookup(ev);

// None of the modifiers should be pressed
Expand Down