Skip edit-previous shortcut during IME composition - #7904
Open
ayubun wants to merge 1 commit into
Open
Conversation
ayubun
force-pushed
the
fix-japanese-macos
branch
from
June 2, 2026 21:18
d5a6e6e to
ae7c460
Compare
Contributor
|
Hi! Thanks for this. I confirmed the fix, and we've merged it internally with a small change (the app runs on electron, so safari checks are not needed). It should show up after the next release cycle in about a week. |
pull Bot
pushed a commit
to xiaoqinglee/Signal-Desktop
that referenced
this pull request
Jun 10, 2026
Co-authored-by: ayu <ayu@ayu.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
When in an IME composition (i.e. selecting a Japanese transliteration), Signal's
edit-previousshortcut will still be callable, as described in the #7898 issue (with a video example)This PR fixes #7898 and was tested locally:
Screen.Recording.2026-06-02.at.2.07.11.PM.mov