Skip to content

Use np.ndarray in generic types #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jl-wynen merged 1 commit into from
Aug 18, 2026
+3 −4
Merged

Use np.ndarray in generic types #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/complex_workflow_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class RawData:
class Raw(sl.Scope[Run, RawData], RawData): ...


class Masked(sl.Scope[Run, npt.NDArray[np.float64]], npt.NDArray[np.float64]): ...
class Masked(sl.Scope[Run, np.ndarray], np.ndarray): ...


class IncidentMonitor(sl.Scope[Run, float], float): ...
Expand All @@ -41,7 +41,7 @@ class TransmissionMonitor(sl.Scope[Run, float], float): ...
class TransmissionFraction(sl.Scope[Run, float], float): ...


class IofQ(sl.Scope[Run, npt.NDArray[np.float64]], npt.NDArray[np.float64]): ...
class IofQ(sl.Scope[Run, np.ndarray], np.ndarray): ...


BackgroundSubtractedIofQ = NewType('BackgroundSubtractedIofQ', npt.NDArray[np.float64])
Expand Down
3 changes: 1 addition & 2 deletions tests/pipeline_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
from typing import Any, Generic, NewType, TypeVar

import numpy as np
import numpy.typing as npt
import pydantic
import pytest

Expand Down Expand Up @@ -254,7 +253,7 @@ def test_subclasses_of_generic_array_provider_defined_with_Scope_work() -> None:
# int is unused, but a single constraint is not allowed by Python
Param = TypeVar('Param', str, int)

class ArrayT(sl.Scope[Param, npt.NDArray[np.int64]], npt.NDArray[np.int64]): ...
class ArrayT(sl.Scope[Param, np.ndarray], np.ndarray): ...

class Array1(ArrayT[Param]): ...

Expand Down
Loading