Use np.ndarray in generic types - #234
Merged
Merged
Conversation
The previous npt.NDArray[...] clashes with `typing.Generic` coming from `sciline.Scope`. Functionally, there is no reason to inherit from or parametrise by npt.NDArray.
jl-wynen
enabled auto-merge
August 18, 2026 16:19
MridulS
approved these changes
Aug 18, 2026
Member
|
Thanks, should #233 be closed? |
Member
Author
Depends on whether you want to figure out how to handle py3.12 generics. Or if we should just leave everything as is and accept that users can run into this error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous npt.NDArray[...] clashes with
typing.Genericcoming fromsciline.Scope. Functionally, there is no reason to inherit from or parametrise by npt.NDArray.This fixes the immediate error in #233. This will not currently be tested with a version that triggers the failure because I do not want to add a new Python 3.12 test since we will soon drop support for 3.11 anyway.