Skip to content

winit-wayland: add new font backend features - #4640

Open
HigherOrderLogic wants to merge 1 commit into
rust-windowing:masterfrom
HigherOrderLogic:master
Open

winit-wayland: add new font backend features#4640
HigherOrderLogic wants to merge 1 commit into
rust-windowing:masterfrom
HigherOrderLogic:master

Conversation

@HigherOrderLogic

Copy link
Copy Markdown

As title.

P/s: Sctk-adwaita has added new skrifa and cosmic-text backend for text rendering, do we want to add those as features of winit-wayland?

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@kchibisov

Copy link
Copy Markdown
Member

I guess we can add features just for completeness 🤔

@HigherOrderLogic

Copy link
Copy Markdown
Author

Seems like CI failures are due to new Syn v3.

@HigherOrderLogic
HigherOrderLogic force-pushed the master branch 3 times, most recently from 52e2ff8 to 8a5c6c7 Compare July 23, 2026 15:49
@torokati44

torokati44 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

It would be nice to also add feature flags to select the recently added font renderer options:

Just like the preexisting one for crossfont.

EDIT: Ah sorry it's already there... 😶 Awesome!

@HigherOrderLogic

Copy link
Copy Markdown
Author

I already added it.

https://github.com/rust-windowing/winit/pull/4640/changes#diff-68bad72e78b1bab5c90d48dc9aa990823720cf5a754aed5b8e8a544d53f9d8b5R58-R62

I think the only blocker right now is figuring out which deps need to be upgraded to pass cargo-deny.

@torokati44

Copy link
Copy Markdown
Contributor

Yep, just noticed now, sorry for the noise!

@torokati44

Copy link
Copy Markdown
Contributor

@HigherOrderLogic

Copy link
Copy Markdown
Author

Imo we better wait for a new cosmic-text release with skrifa bumped. This repo doesnt have a Cargo.lock so I dont think that command will work.

@oscargus

Copy link
Copy Markdown

This repo doesnt have a Cargo.lock

Interesting to have a deny check then as cargo will just pick the maximum version possible rather than unify the versions. One may almost claim this is incorrect use of cargo deny. It is not like there isn't a solution with a single version, just that cargo doesn't bother to find it.

Anyway, hopefully there will be a range for cosmic-text and then this will not be a problem (as long as the upper limit is the same...).

@torokati44

Copy link
Copy Markdown
Contributor

Also, I think the recommendation has been for a while now to also have Cargo.lock checked in for library crates.

@kchibisov

Copy link
Copy Markdown
Member

We bumped sctk-adwaita to 0.12.0 can you just rebase it to add features?

@HigherOrderLogic HigherOrderLogic changed the title winit-wayland: bump sctk-adwaita winit-wayland: add new font backend features Jul 27, 2026
@kchibisov

Copy link
Copy Markdown
Member

You need to handle cargo-deny one way or another since it's from your changes.

@HigherOrderLogic

Copy link
Copy Markdown
Author

Should I just skip it in deny.toml then?

@kchibisov

Copy link
Copy Markdown
Member

well, skip + add comment why.

@HigherOrderLogic
HigherOrderLogic force-pushed the master branch 2 times, most recently from 0f95d37 to ef86f01 Compare August 1, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants