winit-wayland: add new font backend features - #4640
Conversation
|
I guess we can add features just for completeness 🤔 |
|
Seems like CI failures are due to new Syn v3. |
52e2ff8 to
8a5c6c7
Compare
|
It would be nice to also add feature flags to select the recently added font renderer options:
Just like the preexisting one for EDIT: Ah sorry it's already there... 😶 Awesome! |
|
I already added it. I think the only blocker right now is figuring out which deps need to be upgraded to pass |
|
Yep, just noticed now, sorry for the noise! |
|
Imo we better wait for a new |
Interesting to have a deny check then as cargo will just pick the maximum version possible rather than unify the versions. One may almost claim this is incorrect use of cargo deny. It is not like there isn't a solution with a single version, just that cargo doesn't bother to find it. Anyway, hopefully there will be a range for cosmic-text and then this will not be a problem (as long as the upper limit is the same...). |
|
Also, I think the recommendation has been for a while now to also have Cargo.lock checked in for library crates. |
|
We bumped sctk-adwaita to 0.12.0 can you just rebase it to add features? |
sctk-adwaita|
You need to handle cargo-deny one way or another since it's from your changes. |
|
Should I just skip it in |
|
well, skip + add comment why. |
0f95d37 to
ef86f01
Compare
As title.
P/s: Sctk-adwaita has added new
skrifaandcosmic-textbackend for text rendering, do we want to add those as features ofwinit-wayland?changelogmodule if knowledge of this change could be valuable to users