Skip to content

chore: bump skrifa + harfrust - #513

Open
akx wants to merge 3 commits into
pop-os:mainfrom
akx:skrifa-042
Open

chore: bump skrifa + harfrust#513
akx wants to merge 3 commits into
pop-os:mainfrom
akx:skrifa-042

Conversation

@akx

@akx akx commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This makes the default build's dep graph unify on a single read-fonts 0.39.x + single version of skrifa.

Before

~/b/cosmic-text (main) $ git rev-parse HEAD
c24886c2471e5606587c46090cd25dbbf209186b
~/b/cosmic-text (main) $ cargo build -q
~/b/cosmic-text (main) $ cargo tree -d -e normal
read-fonts v0.37.0
├── harfrust v0.5.2
│   └── cosmic-text v0.19.0 (/Users/akx/build/cosmic-text)
└── skrifa v0.40.0
    └── cosmic-text v0.19.0 (/Users/akx/build/cosmic-text)
read-fonts v0.39.2
└── skrifa v0.42.1
    └── swash v0.2.9
        └── cosmic-text v0.19.0 (/Users/akx/build/cosmic-text)
skrifa v0.40.0 (*)
skrifa v0.42.1 (*)

After

~/b/cosmic-text (skrifa-042) $ cargo build -q
~/b/cosmic-text (skrifa-042) $ cargo tree -d -e normal
warning: nothing to print.

harfrust's shape_with_plan had become private in 0.8.0, so change that use.


  • I have disclosed use of any AI generated code in my commit messages.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
    • cargo test passes, and an upstream app using this code seems to work as before.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

jackpot51
jackpot51 previously approved these changes Jun 27, 2026
@akx

akx commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Hmm... It built fine on my machine 😅

@hojjatabdollahi

Copy link
Copy Markdown
Contributor

Make sure to compile it with no-std feature too.

Comment thread Cargo.toml Outdated
This makes the dep graph unify on read-fonts 0.39.x.
@norepro

norepro commented Jul 11, 2026

Copy link
Copy Markdown

Not sure if this should be separate or a change to this PR but, if you can update harfrust to 0.11.0 or newer, it would also fix pop-os/cosmic-files#1895 (once it takes whatever release of cosmic-text has this change).

@akx

akx commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Not sure if this should be separate or a change to this PR but, if you can update harfrust to 0.11.0 or newer

Ah yeah, that wasn't an option when I opened this PR, since that would've pulled in multiple versions of font-types, but since Skrifa has since updated, let's see... googlefonts/fontations@cd4aaef

EDIT: Not right now, because that will require cooperation from Swash as well, or otherwise we're again pulling in two different skrifas and read-fontses. I've created an upstream PR: dfrg/swash#131

@oscargus

Copy link
Copy Markdown

Maybe add a range for skrifa (and harfrust)?

It is indeed a bit annoying to have to synchronize bumped version over lots of crates...

@HigherOrderLogic

Copy link
Copy Markdown

I also prefer a range here, which would help rust-windowing/winit#4640. Currently, cargo deny is complaining about 2 different skrifa and harfrust version from cosmic-text and sctk-adwaita itself.

@akx

akx commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@norepro The Swash PR was merged, so I added another commit to further bump to harfrust 0.12.0, skrifa 0.44.0, swash 0.2.10.

@oscargus @HigherOrderLogic What kind of range would you suggest? 🤔

@oscargus

Copy link
Copy Markdown

@oscargus

Copy link
Copy Markdown

Or really as large as possible, but a bit tedious to test too many... For winit, I think the main thing is that the upper range is not higher than 0.44. (Now 0.45 is released...)

@HigherOrderLogic

Copy link
Copy Markdown

For winit, I think the main thing is that the upper range is not higher than 0.44

I dont think Winit uses skrifa directly, but it's from sctk-adwaita instead. Ideally, the skrifa range in cosmic-text should match what's there in sctk-adwaita, but I dont know how hard it is to keep them up to date with each other.

@oscargus

Copy link
Copy Markdown

Yeah, it is more that winit runs a cargo deny job that will complain when cargo resolves to different versions. (Although I think they allowed multiple skrifa versions.)

@oscargus

Copy link
Copy Markdown

Which I realize that you know @HigherOrderLogic ... Just wanted to motivate that statement.

@akx akx mentioned this pull request Jul 30, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants