chore: bump skrifa + harfrust - #513
Conversation
|
Hmm... It built fine on my machine 😅 |
|
Make sure to compile it with no-std feature too. |
This makes the dep graph unify on read-fonts 0.39.x.
|
Not sure if this should be separate or a change to this PR but, if you can update |
Ah yeah, that wasn't an option when I opened this PR, since that would've pulled in multiple versions of EDIT: Not right now, because that will require cooperation from Swash as well, or otherwise we're again pulling in two different |
|
Maybe add a range for skrifa (and harfrust)? It is indeed a bit annoying to have to synchronize bumped version over lots of crates... |
|
I also prefer a range here, which would help rust-windowing/winit#4640. Currently, |
|
@norepro The Swash PR was merged, so I added another commit to further bump to harfrust 0.12.0, skrifa 0.44.0, swash 0.2.10. @oscargus @HigherOrderLogic What kind of range would you suggest? 🤔 |
|
Or really as large as possible, but a bit tedious to test too many... For winit, I think the main thing is that the upper range is not higher than 0.44. (Now 0.45 is released...) |
I dont think Winit uses |
|
Yeah, it is more that winit runs a cargo deny job that will complain when cargo resolves to different versions. (Although I think they allowed multiple skrifa versions.) |
|
Which I realize that you know @HigherOrderLogic ... Just wanted to motivate that statement. |
This makes the default build's dep graph unify on a single read-fonts 0.39.x + single version of skrifa.
Before
After
harfrust's
shape_with_planhad become private in 0.8.0, so change that use.cargo testpasses, and an upstream app using this code seems to work as before.