Skip to content

Feature/log timestamp #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZsBT wants to merge 3 commits into from
Closed

Feature/log timestamp #90

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d6e110
logging with timestamp
Sep 4, 2025
0a5f9bf
add startup message
Sep 4, 2025
9bf7587
Merge branch 'rofl0r:master' into feature/log-timestamp
ZsBT Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion sockssrv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
#include <limits.h>
#include "server.h"
#include "sblist.h"
#include <time.h>
#include <stdarg.h>

/* timeout in microseconds on resource exhaustion to prevent excessive
cpu usage. */
Expand Down Expand Up @@ -111,7 +113,20 @@ struct thread {
/* we log to stderr because it's not using line buffering, i.e. malloc which would need
locking when called from different threads. for the same reason we use dprintf,
which writes directly to an fd. */
#define dolog(...) do { if(!quiet) dprintf(2, __VA_ARGS__); } while(0)
static inline void dolog(const char *fmt, ...) {

@rofl0r rofl0r Aug 29, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your code ignores the quiet flag. also inline inserts the code at every callsite, bloating the binary. since logging is not performance sensitive, this should only be static. also localtime_r isn't available on all platforms afaik (even though it's in my POSIX 2008 manpages).

@ZsBT ZsBT Sep 3, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the findings. I'll close this PR to open a new one.

char t[32] = {};
struct tm tm_buf;
time_t secs = time(NULL);

va_list args;
va_start(args, fmt);

strftime(t, sizeof(t), "[%Y-%m-%d %T] ", localtime_r(&secs, &tm_buf));
dprintf(fileno(stderr), "%s", t);
vdprintf(fileno(stderr), fmt, args);

va_end(args);
}
#else
static void dolog(const char* fmt, ...) { }
#endif
Expand Down Expand Up @@ -481,6 +496,7 @@ int main(int argc, char** argv) {
return 1;
}
server = &s;
dolog("Listening on %s:%d\n", listenip, port);

while(1) {
collect(threads);
Expand Down