Feature/log timestamp - #90
Closed
ZsBT wants to merge 3 commits into
Closed
Conversation
added 2 commits
September 4, 2025 23:09
Author
|
Kept an eye on the review of a similar PR #70 |
rofl0r
reviewed
Aug 29, 2026
| locking when called from different threads. for the same reason we use dprintf, | ||
| which writes directly to an fd. */ | ||
| #define dolog(...) do { if(!quiet) dprintf(2, __VA_ARGS__); } while(0) | ||
| static inline void dolog(const char *fmt, ...) { |
Owner
There was a problem hiding this comment.
your code ignores the quiet flag. also inline inserts the code at every callsite, bloating the binary. since logging is not performance sensitive, this should only be static. also localtime_r isn't available on all platforms afaik (even though it's in my POSIX 2008 manpages).
Author
There was a problem hiding this comment.
thanks for the findings. I'll close this PR to open a new one.
Author
|
closing as incompatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding timestamp to stderr log, using dprintf, keeping the fmt option.
Also a startup message tells the bind address.