Skip to content

fix(breadcrumb): add aria-current to current item #19570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manichandra wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −0
Open

fix(breadcrumb): add aria-current to current item #19570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions packages/primeng/src/breadcrumb/breadcrumb.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,6 +872,37 @@ describe('Breadcrumb', () => {
expect(breadcrumbInstance.home?.tooltipOptions?.tooltipLabel).toBe('Home tooltip');
expect(breadcrumbInstance.model?.[0]?.tooltipOptions?.tooltipLabel).toBe('Item tooltip');
});

it('should set aria-current on the last non-router item', async () => {
component.model = [
{ label: 'Products', url: '/products' },
{ label: 'Category', url: '/products/category' }
];
fixture.changeDetectorRef.markForCheck();

await fixture.whenStable();

fixture.detectChanges();

const itemLinks = fixture.debugElement.queryAll(By.css('[data-pc-section="item"] a'));

expect(itemLinks[0].nativeElement.getAttribute('aria-current')).toBeNull();
expect(itemLinks[1].nativeElement.getAttribute('aria-current')).toBe('page');
});

it('should set aria-current on the active last router item', async () => {
const routerFixture = TestBed.createComponent(TestRouterBreadcrumbComponent);

await router.navigateByUrl('/products/category');
routerFixture.detectChanges();
await routerFixture.whenStable();
routerFixture.detectChanges();

const itemLinks = routerFixture.debugElement.queryAll(By.css('[data-pc-section="item"] a'));

expect(itemLinks[0].nativeElement.getAttribute('aria-current')).toBeNull();
expect(itemLinks[1].nativeElement.getAttribute('aria-current')).toBe('page');
});
});

describe('Edge Cases', () => {
Expand Down
2 changes: 2 additions & 0 deletions packages/primeng/src/breadcrumb/breadcrumb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ const BREADCRUMB_INSTANCE = new InjectionToken<Breadcrumb>('BREADCRUMB_INSTANCE'
[attr.title]="menuitem?.title"
[attr.tabindex]="menuitem?.disabled ? null : menuitem?.tabindex || '0'"
[attr.data-automationid]="menuitem?.automationId"
[attr.aria-current]="end ? 'page' : undefined"
[pBind]="getPTOptions(menuitem, i, 'itemLink')"
>
<ng-container *ngIf="!itemTemplate && !_itemTemplate">
Expand All @@ -129,6 +130,7 @@ const BREADCRUMB_INSTANCE = new InjectionToken<Breadcrumb>('BREADCRUMB_INSTANCE'
routerLinkActive="p-menuitem-link-active"
[queryParams]="menuitem?.queryParams"
[routerLinkActiveOptions]="menuitem?.routerLinkActiveOptions || { exact: false }"
[ariaCurrentWhenActive]="end ? 'page' : undefined"
[class]="cn(cx('itemLink'), menuitem?.linkClass)"
[ngStyle]="menuitem?.linkStyle"
(click)="onClick($event, menuitem)"
Expand Down
Loading