fix(breadcrumb): add aria-current to current item - #19570
Open
manichandra wants to merge 1 commit into
Open
Conversation
Breadcrumb items did not expose aria-current for the current page, despite the accessibility documentation stating that the current route is represented with aria-current="page". Added aria-current handling for the last breadcrumb item, including router-linked items via ariaCurrentWhenActive. Fixes primefaces#19523
SoyDiego
approved these changes
May 11, 2026
Contributor
Author
|
Happy to rebase if needed — the failing check appears to be a triage workflow issue unrelated to the code changes. |
Contributor
Author
|
@SoyDiego can we get this merged. Thanks |
Contributor
I'm not part of Primeng team. Only a contributor :) |
Contributor
Author
|
@mehmetcetin01140 can we get this merged. let me know if I need to anything to pass the failing CI checks ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breadcrumb items did not expose aria-current for the current page, despite the accessibility documentation stating that the current route is represented with aria-current="page".
Added aria-current handling for the last breadcrumb item, including router-linked items via ariaCurrentWhenActive.
Fixes #19523
Defect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.