Implement legacy bar hit error meter - #38535
Merged
Merged
Conversation
This `1.6f` constant repeats too much everywhere and I am not about to repeat it once more. I will do a pass on all of the places that inline this (and there are many) as a follow-up.
Literally every time with this test.
Contributor
|
just curious, why different colors? |
Collaborator
Author
|
Because they are the same standard colours used all over lazer for hit results and I am not changing them for this. |
Member
|
One thing the stable hit error bar did was fade out when there were no recent hits. Doesn't necessarily have to happen here, let's wait and see if people point it out post release. Might be something which is better re-implemented on a higher level (ie there's probably other components that players may want to fade in/out in a similar way, so being able to apply to arbitrary skin components might be nice). |
peppy
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hit.error.meter.-.HD.1080p.mov
Things matching stable:
Things intentionally not matching stable:
Triangle)Follow-ups / scope limits:
1.6fconstant that shows up everywhere in 443f09d (see also: Implement legacy back button UI #37676 (comment)). I have not however attempted to replace all inline references to1.6fwith the const here, I would ask that to be considered for a separate PR.stable would use the colour hit meter style instead here. Bringing back parity in that respect was attempted in Use colour hit error meter in catch #38269.