Use colour hit error meter in catch - #38269
Conversation
|
Code seems mostly fine on a skim, but unsure of several subjective decisions made here.
Will need @peppy or someone design-adjacent to state preferences on all of the above. |
https://github.com/user-attachments/assets/8b01d637-8e7e-482f-a6a4-d36202ad33cb | | stable | this PR | | :-: | :-: | :-: | | osu!, OD=0 | <img width="400" height="50" alt="stable-osu-od0" src="https://github.com/user-attachments/assets/9ba522dd-5bdc-46c7-a79c-92809f96a9a4" /> | <img width="400" height="50" alt="lazer-osu-od0" src="https://github.com/user-attachments/assets/8b6603ef-8152-4e86-94a6-9f9d30633f8f" /> | | osu!, OD=5 | <img width="400" height="50" alt="stable-osu-od5" src="https://github.com/user-attachments/assets/29172d7f-05c0-4fbd-9810-2bbfcd570e4f" /> | <img width="400" height="50" alt="lazer-osu-od5" src="https://github.com/user-attachments/assets/844f4310-47ee-4b72-bc77-a7f40963a54e" /> | | osu!, OD=10 | <img width="400" height="50" alt="stable-osu-od10" src="https://github.com/user-attachments/assets/34afc432-5026-4da5-a6e1-7767b21e4382" /> | <img width="400" height="50" alt="lazer-osu-od10" src="https://github.com/user-attachments/assets/d34bfe61-25f1-4f54-8e5c-dbeeda0e1de7" /> | | taiko, OD=0 | <img width="400" height="50" alt="stable-taiko-od0" src="https://github.com/user-attachments/assets/e8b729cf-aa48-4443-932f-3e7a21fcca87" /> | <img width="400" height="50" alt="lazer-taiko-od0" src="https://github.com/user-attachments/assets/b7bb987f-9e24-4922-8b9c-88fd0b5c8ea0" /> | | taiko, OD=5 | <img width="400" height="50" alt="stable-taiko-od5" src="https://github.com/user-attachments/assets/fe984671-8755-4c34-9242-a1d4934d8dca" /> | <img width="400" height="50" alt="lazer-taiko-od5" src="https://github.com/user-attachments/assets/178eb7c7-c1cf-4466-80ce-afeb9d1a1062" /> | | taiko, OD=10 | <img width="400" height="50" alt="stable-taiko-od10" src="https://github.com/user-attachments/assets/e2c7e2c3-e00f-4e14-8b9d-5f92d8d7da8c" /> | <img width="400" height="50" alt="lazer-taiko-od10" src="https://github.com/user-attachments/assets/e6e52fa7-8e1d-4ac7-bd0d-fc1c8ccb48f3" /> | | mania, OD=0 | <img width="400" height="50" alt="stable-mania-od0" src="https://github.com/user-attachments/assets/a9f6f65b-c1c8-4241-9b51-72c957be38bf" /> | <img width="400" height="50" alt="lazer-mania-od0" src="https://github.com/user-attachments/assets/dcf001bb-024d-4c63-9169-3c30555b4d9d" /> | | mania, OD=5 | <img width="400" height="50" alt="stable-mania-od5" src="https://github.com/user-attachments/assets/9b369c35-aaaa-4d06-b8b2-5c949ce55524" /> | <img width="400" height="50" alt="lazer-mania-od5" src="https://github.com/user-attachments/assets/f9b4381a-6df6-4781-b067-a9d5e08fc5f6" /> | | mania, OD=10 | <img width="400" height="50" alt="stable-mania-od10" src="https://github.com/user-attachments/assets/7510719e-fb33-4b4c-8d5c-d59de3c9c8ab" /> | <img width="400" height="50" alt="lazer-mania-od10" src="https://github.com/user-attachments/assets/b008347e-496c-49f8-96c5-6c3d84694e88" /> | Things matching stable: - Position of meter on unmodified legacy skins - Size of meter - Scaling of meter width with OD (widths of bars are derived directly from hit windows) - Hit bar size & animation - Moving average arrow animation Things intentionally not matching stable: - Arrow indicator slightly larger (unsure why, measurements taken verbatim from stable - possibly due to not using the same exact png asset and instead using `Triangle`) - Colours intentionally different - MEH bars intentionally not shown in taiko because they are stable lies (nothing in stable taiko uses that hit window) - mania shows bars for PERFECTs and GOODs - Meter does not fade out when there are no recent hits (may be brought back later if there are complaints about it) --- Follow-ups / scope limits: - I have introduced a const for the magic `1.6f` constant that shows up everywhere in 443f09d (see also: #37676 (comment)). I have not however attempted to replace all inline references to `1.6f` with the const here, I would ask that to be considered for a separate PR. - In catch the meter degenerates to the following: <img width="400" height="50" alt="catch-lazer" src="https://github.com/user-attachments/assets/64b7e94e-1907-440e-bae4-ce9cc07ae8cd" /> stable would use the colour hit meter style instead here. Bringing back parity in that respect was attempted in #38269.
|
Have fixed up conflicts - including silent ones - post-#38535 and fixed the spacing issue. Will leave the other subjective matters for someone else to address if necessary. Of particular note, this change may cause some users to end up with skins that have the hit error meter duplicated. This can happen because e.g. when editing a skin in osu! ruleset, the |
ColourHitErrorMeter in catch







Moved HitErrorMeter into ruleset-only layer.
Judgement count, spacing and shape are referenced from Stable