Repository navigation
[Deps] mcp: @hono/node-server 2.1.6 (clears GHSA-rmxm-3fg6-px4f), on top of #1221 - #1222
Merged
Merged
Conversation
… 7.0.163 - next / @next/eslint-plugin-next 16.4.3 -> 16.4.5 (Nov 3 security release) - ai 7.0.163, @ai-sdk/openai 4.0.109, @ai-sdk/anthropic 4.0.97 - tailwindcss / @tailwindcss/postcss 4.3.4; oxide 4.3.4 and lightningcss 1.33.0 platform pins follow @tailwindcss/node - @lingui/* 6.12.0, motion 14.9.1, lucide-react 1.69.0, geist 1.9.1, @iconify/react 6.0.4, three-mesh-bvh 0.9.18 - @biomejs/biome 2.6.5, ultracite 8.1.1, eslint 10.14.0, globals 17.14.0, playwright-core 1.65.0, fast-xml-parser 5.12.0, dotenv-cli 11.1.0, fake-indexeddb 6.2.7, @types/node 26.6.6 - hono override 4.13.16, @hono/node-server 1.19.18
…xture configuredProvider takes its environment as an argument so tests can point the real OpenAI and Anthropic providers at a local HTTP fixture. Covers the Responses API strict JSON schema, Anthropic native structured output and its forced JSON-tool fallback, schema-violating and non-JSON replies, a non-retryable auth error, and ICU validation of provider output.
Boots next start over the built app and checks config redirects and headers, the proxy's locale and self-host gate, server-rendered pages, scene route handlers (including that force-dynamic reads are never stale and stale If-Match writes conflict) and that the image optimizer serves raster images but refuses SVG.
Mounts <SceneBvh> through the R3F test renderer and compares accelerated hits (all hits and firstHitOnly) with three's brute-force raycast on a segmented wall, a CSG wall with an opening, and indexed and non-indexed torus knots, including axis-parallel rays on bound faces. Also checks excluded and degenerate meshes are skipped and that unmount disposes only the trees SceneBvh built.
The serveStatic path-decoding bypass is fixed only in 2.1.3+. Pascal does not call serveStatic; the adapter is reached through @modelcontextprotocol/node's streamable HTTP transport, which already accepts ^2.1.3. v2 keeps the public API and rewrites request/response bridging, so a test now covers a full tool result inside a session and the refusal of a session after DELETE.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Run next start on Node as production does, bound every request and the CI step with timeouts, wait for the server to exit (SIGKILL fallback) and forward interrupts, treat a signal exit as a startup failure, match <html lang> exactly, assert SVG refusal by status and content type, and include the smoke in bun run ci.
3 of 4 tasks
…teardown needs Unmounting stops three's animation loop through cancelAnimationFrame, which Bun does not provide; mirror the polyfill other R3F tests use so teardown completes instead of logging an error.
2 of 4 tasks
…endency branch package.json keeps this branch's upgraded versions and takes main's entities ^9.0.0; bun.lock is this branch's lockfile re-resolved for entities 9.0.0 only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This upgrades
@hono/node-serverfrom 1.19 to 2.1.6 (the@pascal-app/mcpdependency and the root override). The upgrade clears the moderate advisory GHSA-rmxm-3fg6-px4f, whereserveStaticdecodes the request path twice. The advisory covers every version from 1.19.10 up to 2.1.3, so no 1.x release fixes it.Composition with #1221: both PRs changed the
@hono/node-serverrange inpackage.jsonandpackages/mcp/package.json, andbun.lock, from the same base. To avoid a conflict at merge time, this branch now contains #1221 through a normal merge commit. Nothing was rebased or force-pushed.69b0e7d6010a52da275e332b3fc1d424686d9e5ais an ancestor of this branch.e1c5d19c),git diff 69b0e7d6..e1c5d19cchanged only:@hono/node-server^1.19.18 → ^2.1.6, in the root overrides and inpackages/mcpbun.lock, since the lockfile was [Deps] Next 16.4.5 security release, AI SDK 7.0.163 and patch/minor bundle #1221's re-resolved for this package onlymain(theentitiesline andbun.lock), so this PR is the conflict-free way to land both.Update to current
main(Nov 6):d1bed351is a normal merge ofmainata5cd6f3c(through #1229, including entities 9 from #1223).package.jsonkeeps this branch's upgraded versions and takesmain'sentities^9.0.0.bun.lockis the previous head's lockfile, re-resolved forentities9.0.0 only, so the twoentitieslines are the only lockfile change sincee1c5d19c.main, #1221's head69b0e7d6and the previous heade1c5d19care all ancestors.Commits on top of #1221
deps(mcp): @hono/node-server 2.1.6 to clear GHSA-rmxm-3fg6-px4f. Pascal never callsserveStatic; the adapter is reached only through@modelcontextprotocol/node's streamable HTTP transport, which already accepts^1.19.9 || ^2.1.3, so there is a single copy (2.1.6). v2 keeps the public API (v2.0.0 notes), requires Node ≥ 20 and has a peer range ofhono ^4 || ^5.0.0-0. A new test,connectHttp returns a full tool result in a session and refuses it after DELETE, covers the response bridging that v2 rewrote.hono4.13.16 andnext16.4.5 overrides.test(viewer): give the SceneBvh test the animation-frame globals R3F teardown needs. R3F's unmount stops three's animation loop throughcancelAnimationFrame, which Bun lacks. The fix is the same??=polyfill other R3F tests use, and it removes the[R3F] Error while unmounting rootlog from this test.mainata5cd6f3c, described above.How to test
bun install --frozen-lockfile: exactly one@hono/node-server@2.1.6, with Next 16.4.5, hono 4.13.16 and entities 9.0.0.bun audit: the@hono/node-serveradvisory is gone. Only the dev-only minimatch and deepmerge advisories remain.bun run ci: passes locally on this head, including the production-server smoke, the AI SDK provider fixture tests, the BVH differential test, the MCP HTTP session test and the entities scanner test.Screenshots / screen recording
N/A — non-visual change
Checklist
bun devbun checkto verify)mainbranchRollout and rollback: there's no data migration. Production surfaces affected: everything listed in #1221, plus the MCP HTTP transport (
pascal-mcp --httpand the CLI's managed MCP service) and the published@pascal-app/mcpdependency range. To roll back, revert the merge, or revert only the node-server commit to keep #1221.Note
Medium Risk
Broad framework/runtime upgrades plus new long-running smoke tests can surface regressions in editor routing or MCP HTTP, though changes are heavily guarded by automated coverage.
Reviewed by Cursor Bugbot for commit d1bed35. Bugbot is set up for automated code reviews on this repo. Configure here.