Repository navigation
Conversation
… 7.0.163 - next / @next/eslint-plugin-next 16.4.3 -> 16.4.5 (Nov 3 security release) - ai 7.0.163, @ai-sdk/openai 4.0.109, @ai-sdk/anthropic 4.0.97 - tailwindcss / @tailwindcss/postcss 4.3.4; oxide 4.3.4 and lightningcss 1.33.0 platform pins follow @tailwindcss/node - @lingui/* 6.12.0, motion 14.9.1, lucide-react 1.69.0, geist 1.9.1, @iconify/react 6.0.4, three-mesh-bvh 0.9.18 - @biomejs/biome 2.6.5, ultracite 8.1.1, eslint 10.14.0, globals 17.14.0, playwright-core 1.65.0, fast-xml-parser 5.12.0, dotenv-cli 11.1.0, fake-indexeddb 6.2.7, @types/node 26.6.6 - hono override 4.13.16, @hono/node-server 1.19.18
…xture configuredProvider takes its environment as an argument so tests can point the real OpenAI and Anthropic providers at a local HTTP fixture. Covers the Responses API strict JSON schema, Anthropic native structured output and its forced JSON-tool fallback, schema-violating and non-JSON replies, a non-retryable auth error, and ICU validation of provider output.
Boots next start over the built app and checks config redirects and headers, the proxy's locale and self-host gate, server-rendered pages, scene route handlers (including that force-dynamic reads are never stale and stale If-Match writes conflict) and that the image optimizer serves raster images but refuses SVG.
Mounts <SceneBvh> through the R3F test renderer and compares accelerated hits (all hits and firstHitOnly) with three's brute-force raycast on a segmented wall, a CSG wall with an opening, and indexed and non-indexed torus knots, including axis-parallel rays on bound faces. Also checks excluded and degenerate meshes are skipped and that unmount disposes only the trees SceneBvh built.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cf4eb31b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| try { | ||
| server = spawn( | ||
| process.execPath, |
There was a problem hiding this comment.
Run the production smoke server under Node
In the inspected CI workflow, bun run smoke launches this file through Bun, so process.execPath resolves to the Bun executable and the Next server is also run under Bun. The shipped editor instead starts its production server with node (packages/cli/src/editor-process.ts:234-240), while CI explicitly installs Node 22.23.4. This means Node-specific Next or route-handler regressions can pass the new compatibility test—and Bun-specific failures can block CI—despite the test claiming to exercise the production server; spawn the configured Node binary rather than process.execPath.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2cf4eb3. Configure here.
Run next start on Node as production does, bound every request and the CI step with timeouts, wait for the server to exit (SIGKILL fallback) and forward interrupts, treat a signal exit as a startup failure, match <html lang> exactly, assert SVG refusal by status and content type, and include the smoke in bun run ci.
…top of #1221 (#1222) * deps: patch/minor bumps incl. Next 16.4.5 security release and AI SDK 7.0.163 - next / @next/eslint-plugin-next 16.4.3 -> 16.4.5 (Nov 3 security release) - ai 7.0.163, @ai-sdk/openai 4.0.109, @ai-sdk/anthropic 4.0.97 - tailwindcss / @tailwindcss/postcss 4.3.4; oxide 4.3.4 and lightningcss 1.33.0 platform pins follow @tailwindcss/node - @lingui/* 6.12.0, motion 14.9.1, lucide-react 1.69.0, geist 1.9.1, @iconify/react 6.0.4, three-mesh-bvh 0.9.18 - @biomejs/biome 2.6.5, ultracite 8.1.1, eslint 10.14.0, globals 17.14.0, playwright-core 1.65.0, fast-xml-parser 5.12.0, dotenv-cli 11.1.0, fake-indexeddb 6.2.7, @types/node 26.6.6 - hono override 4.13.16, @hono/node-server 1.19.18 * docs: apply Biome 2.6.5 Markdown formatting (blank line before lists) * test(i18n): drive the AI SDK translation providers against a local fixture configuredProvider takes its environment as an argument so tests can point the real OpenAI and Anthropic providers at a local HTTP fixture. Covers the Responses API strict JSON schema, Anthropic native structured output and its forced JSON-tool fallback, schema-violating and non-JSON replies, a non-retryable auth error, and ICU validation of provider output. * ci(editor): smoke-test the production Next server after the build Boots next start over the built app and checks config redirects and headers, the proxy's locale and self-host gate, server-rendered pages, scene route handlers (including that force-dynamic reads are never stale and stale If-Match writes conflict) and that the image optimizer serves raster images but refuses SVG. * test(viewer): pin SceneBvh raycasts to stock three on real geometry Mounts <SceneBvh> through the R3F test renderer and compares accelerated hits (all hits and firstHitOnly) with three's brute-force raycast on a segmented wall, a CSG wall with an opening, and indexed and non-indexed torus knots, including axis-parallel rays on bound faces. Also checks excluded and degenerate meshes are skipped and that unmount disposes only the trees SceneBvh built. * deps(mcp): @hono/node-server 2.1.6 to clear GHSA-rmxm-3fg6-px4f The serveStatic path-decoding bypass is fixed only in 2.1.3+. Pascal does not call serveStatic; the adapter is reached through @modelcontextprotocol/node's streamable HTTP transport, which already accepts ^2.1.3. v2 keeps the public API and rewrites request/response bridging, so a test now covers a full tool result inside a session and the refusal of a session after DELETE. * ci(editor): harden the production server smoke Run next start on Node as production does, bound every request and the CI step with timeouts, wait for the server to exit (SIGKILL fallback) and forward interrupts, treat a signal exit as a startup failure, match <html lang> exactly, assert SVG refusal by status and content type, and include the smoke in bun run ci. * test(viewer): compare tied BVH hits by where the ray stops * deps: dedupe nested minimatch onto the hoisted 10.2.6 * test(viewer): give the SceneBvh test the animation-frame globals R3F teardown needs Unmounting stops three's animation loop through cancelAnimationFrame, which Bun does not provide; mirror the polyfill other R3F tests use so teardown completes instead of logging an error. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>

What does this PR do?
Patch/minor dependency refresh (2026-11-06), led by the Next.js 16.4.5 security release, plus compatibility tests for the boundaries these upgrades touch. Majors are left out and listed below.
Upgrades
next, root override,@next/eslint-plugin-next/api/plugins/mint/[...path]forwards fetched responses) and the image-optimizer SVG bypass (GHSA-7qx7-33qx-rqx2;images.remotePatternsallows**). 16.4.4 contains backported fixes only.ai@ai-sdk/openai@ai-sdk/anthropic@ai-sdk/provider4.0.36 and@ai-sdk/provider-utils5.0.75.tailwindcss,@tailwindcss/postcss@tailwindcss/oxide-*pins move to 4.3.4 and thelightningcss-*pins to 1.33.0, matching what@tailwindcss/node@4.3.4requires.@lingui/{core,message-utils,cli,conf,format-po}@lingui/message-utilsnow uses@noble/hashes2.x instead ofjs-sha256, so that package becomes a runtime transitive of@pascal-app/core.motion14.9.1,lucide-react1.69.0,geist1.9.1,@iconify/react6.0.4,three-mesh-bvh0.9.18@biomejs/biome2.6.5,ultracite8.1.1,eslint10.14.0,globals17.14.0,playwright-core1.65.0,fast-xml-parser5.12.0,dotenv-cli11.1.0,fake-indexeddb6.2.7,@types/node26.6.6honooverride@hono/node-serverAlready at the latest stable and unchanged: React/React DOM 19.3.1, three 0.187.0 and
@types/three,@react-three/fiber9.8.2, drei 10.7.9, xr 6.6.32, zustand 5.0.16, zod 4.6.7, TypeScript 7.0.2, turbo 2.11.10, MCP SDK 2.4.0, Bun 1.4.4, and Node 22.23.4 in Docker and CI. Stripe, Drizzle, Supabase, Sentry, PostHog, Base UI and Expo are not dependencies of this repo. Nestedminimatchcopies were deduped onto the hoisted 10.2.6, andbun install --frozen-lockfilereproduces the lockfile.Integration fix required by the upgrade: Biome 2.6.4–2.6.5 changed its Markdown formatter, which now inserts a blank line before lists. 10 Markdown files are reformatted. The changes are whitespace-only and render the same.
New compatibility tests
scripts/i18n-provider.test.tsdrives the real@ai-sdk/openaiand@ai-sdk/anthropicproviders throughconfiguredProvider(the i18n translation command) against a localBun.servefixture, with no live calls. It covers:jsontool fallback for models without itconfiguredProvidernow takes its environment as an argument (defaulting toprocess.env) so the tests don't mutate global env.apps/editor/scripts/smoke-production-server.ts(bun run smoke) runs as a new CI step after Build, with a 5-minute timeout, and at the end ofbun run ci. It bootsnext starton Node over the production build and checks:/embedCSP header?langthrough to the server-rendered<html lang>HostIf-Match/project/[id]Every request has a timeout. The server is waited on, with a SIGKILL fallback, and interrupts are forwarded to it.
packages/viewer/src/components/viewer/scene-bvh.test.tsxmounts<SceneBvh>with@react-three/test-rendererand compares BVH-accelerated hits with three's brute-force raycast. The geometry is a segmented wall, a CSG wall with an opening, and indexed and non-indexed torus knots. It runs both all-hits andfirstHitOnly, including axis-parallel rays on bound faces, and checks how excluded and degenerate meshes are handled and how trees are disposed. three-mesh-bvh 0.9.17 rewrote BVH construction.Coverage gaps: the i18n tool doesn't use AI streaming, tool calls or cancellation, so none are tested. The image optimizer's handling of remote URLs isn't exercised, because the optimizer refuses loopback hosts by design. No WebGL rendering runs in CI, so interaction coverage is the R3F test renderer plus the existing R3F pointer-event differential suite.
Majors and remaining advisories not in this PR
@hono/node-server1.19 → 2.1.6, which clears GHSA-rmxm-3fg6-px4f (moderate,serveStatic; Pascal doesn't call it). This is in #1222.entities8 → 9 (root dev dependency): needs its own migration.typescript6.0.3 → 7 inpackages/eslint-config: blocked ontypescript-eslintsupport for TS 7.minimatchGHSA-g3hv-75wg-m249 (moderate) anddeepmergeGHSA-gcqx-w48m-w2h4 (low): both are dev-only transitives of the eslint chain and ultracite, and no in-range fix exists upstream.hono5 is only at rc, so it isn't adopted.How to test
bun install --frozen-lockfile: the lockfile is reproducible.bun run ci: lint, i18n check, skill validation, typecheck, tests, build and the production-server smoke all pass locally.bun test scripts/i18n-provider.test.tsandcd packages/viewer && bun test src/components/viewer/scene-bvh.test.tsx.Screenshots / screen recording
N/A — non-visual change
Checklist
bun devbun checkto verify)mainbranchRollout and rollback: these are library upgrades with no data or schema migration. Revert the PR to roll back; the lockfile restores the previous resolution exactly. Production surfaces affected: the editor Next app (routes, proxy, image optimizer, CSS build), the published
@pascal-app/{core,editor,viewer,mcp,nodes}packages (Lingui 6.12, motion, lucide and three-mesh-bvh ranges), the CLI web runtime archive built from the editor, and the i18n translate tooling (dev-only).