-
-
Notifications
You must be signed in to change notification settings - Fork 711
Create PULL_REQUEST_TEMPLATE.md #23523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sureshjoshi
wants to merge
2
commits into
main
Choose a base branch
from
pr-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| ## Description | ||
|
|
||
| _What problem does this PR solve, why is it needed, and how did you solve it? Link any related issues._ | ||
|
|
||
| ## Testing | ||
|
|
||
| _How did you verify this change? Are there any sharp edges that you're unsure about?_ | ||
|
|
||
| ## LLM Assistance Disclosure | ||
|
|
||
| _Per the [Contribution overview — LLM Assistance Notice](https://www.pantsbuild.org/stable/docs/contributions#llm-assistance-notice), disclose any use of AI/LLM assistance in writing, introspecting, reading, reasoning about, debugging, or testing this change._ | ||
|
|
||
| <!-- | ||
| If you used an LLM, describe how. Examples from our policy: | ||
|
|
||
| - "This PR was written primarily by Claude Code." | ||
| - "ChatGPT looked for prior art and came up with the approach but I wrote the code manually." | ||
| - "I used an LLM to generate all of the test cases first, and then I wrote the code." | ||
|
|
||
| You may also use inline PR comments to call out specific LLM-assisted parts. | ||
| --> | ||
|
|
||
| ## Release notes | ||
|
|
||
| _If this change needs release notes, add or update entries under `docs/notes/`. Otherwise, a maintainer can label the PR with `release-notes:not-required`._ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we just link the versioned file here for current release? If we have an AI skill in place for doing "next version" procedure, then the skill can have the instruction to advance the version. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://tombedor.dev/human-attention-and-human-effort/
I find this post to say what I think on this subject.