Create PULL_REQUEST_TEMPLATE.md - #23523
Open
sureshjoshi wants to merge 2 commits into
Open
Conversation
sureshjoshi
added
category:documentation
release-notes:not-required
Forgot italics
Member
Author
|
I mentioned this PR template on several meetings, but then kept forgetting to execute on it. |
tdyas
reviewed
Jul 11, 2026
|
|
||
| ## Release notes | ||
|
|
||
| _If this change needs release notes, add or update entries under `docs/notes/`. Otherwise, a maintainer can label the PR with `release-notes:not-required`._ |
Contributor
There was a problem hiding this comment.
Can we just link the versioned file here for current release?
If we have an AI skill in place for doing "next version" procedure, then the skill can have the instruction to advance the version.
benjyw
approved these changes
Jul 12, 2026
tobni
reviewed
Jul 12, 2026
|
|
||
| ## LLM Assistance Disclosure | ||
|
|
||
| _Per the [Contribution overview — LLM Assistance Notice](https://www.pantsbuild.org/stable/docs/contributions#llm-assistance-notice), disclose any use of AI/LLM assistance in writing, introspecting, reading, reasoning about, debugging, or testing this change._ |
Contributor
There was a problem hiding this comment.
https://tombedor.dev/human-attention-and-human-effort/
I find this post to say what I think on this subject.
tobni
approved these changes
Jul 12, 2026
Contributor
|
Today when one ones a PR, the description is the text of the commit. In most cases I think this is what one would want. With a PR template, where does said text go? Above the template? Below? Thrown away? Interpolated with a variable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What problem does this change solve, why is it needed, and how did you solve it? Link any related issues.
Closes #23080 - with churn from 2021 (#11884)
Basically, just to remind PR creators that we have AI disclosures, and that all other communication is supposed to be human crafted.
Also, a lot of PRs crop up without any discussion of testing - which is concerning.
Testing
How did you verify this change? Are there any sharp edges that you're unsure about?
Used the Markdown preview and hoped for the best.
LLM Assistance Disclosure
Per the Contribution overview — LLM Assistance Notice, disclose any use of AI/LLM assistance in writing, introspecting, reading, reasoning about, debugging, or testing this change.
I used Composer 2.5 and Grok 4.5 and pointed them at our contribution guidelines. Then I deleted everything except for the "LLM Assistance Disclosure" section, because it just felt right.
Release notes
If this change needs release notes, add or update entries under
docs/notes/. Otherwise, a maintainer can label the PR withrelease-notes:not-required.