Skip to content

build(jvm): bump Coursier to v2.1.25-M26 to fix transitive dependenci… #23517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thiago-carbonera wants to merge 7 commits into
base: main
Choose a base branch
from
Open

build(jvm): bump Coursier to v2.1.25-M26 to fix transitive dependenci… #23517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a134417
build(jvm): bump Coursier to v2.1.25-M26 to fix transitive dependenci…
thiago-carbonera Jul 10, 2026
a1e6552
docs: Adding a release note for this pull request
thiago-carbonera Jul 10, 2026
a60e611
docs: Improving the release note to include the switch to the officia…
thiago-carbonera Jul 10, 2026
b522915
build(jvm): retain v2.1.24 in known versions for backward compatibility
thiago-carbonera Jul 13, 2026
eb06290
Resolving merge conflicts
thiago-carbonera Jul 13, 2026
e1c724e
chore: trigger CI re-run for flaky test
thiago-carbonera Jul 13, 2026
352faf8
Merge branch 'main' into fix-coursier-version
thiago-carbonera Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/notes/2.34.x.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Fixed an issue where `pants --changed-since` would unnecessarily invalidate all

The `indicatif-spinner` `dynamic_ui_renderer` (default), now renders on a dedicated thread. This should reduce jitter and display a smoother spinner under heavy load.

Bumped the default Coursier version to v2.1.25-M26 to fix a bug where transitive dependencies were incorrectly omitted from lockfiles when resolving non-default versions of intermediate dependencies.

@tobni tobni Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These notes should go under the jvm section I think.


### Goals

Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/jvm/resolve/coursier_fetch_integration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def test_resolve_with_packaging(rule_runner: RuleRunner) -> None:
packaging="jar",
strict=True,
),
file_name="org.bouncycastle_bcprov-jdk15on_jar_1.70.jar",
file_name="org.bouncycastle_bcprov-jdk15on_1.70.jar",
direct_dependencies=Coordinates([]),
dependencies=Coordinates([]),
file_digest=FileDigest(
Expand Down
6 changes: 5 additions & 1 deletion src/python/pants/jvm/resolve/coursier_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,12 @@ class CoursierSubsystem(TemplatedExternalTool):
name = "coursier"
help = "A dependency resolver for the Maven ecosystem. (https://get-coursier.io/)"

default_version = "v2.1.24"
default_version = "v2.1.25-M26"
default_known_versions = [
"v2.1.25-M26|linux_arm64 |68288bcd47a81f3a3bcf0392572d40ec0981172bba9055a8b662413691358be9|30241456|https://github.com/coursier/coursier/releases/download/v2.1.25-M26/cs-aarch64-pc-linux.gz",
"v2.1.25-M26|linux_x86_64|017812b4da91a72fadd3cb0fb97caae4a16cb947a7bd6be2b46e5aa984458cbf|31136143",
"v2.1.25-M26|macos_arm64 |4ebc84fa2fd767dffca3b4e63ed1cd7bc0f55870f98f14207e46e00512043bc4|29762912|https://github.com/coursier/coursier/releases/download/v2.1.25-M26/cs-aarch64-apple-darwin.gz",
"v2.1.25-M26|macos_x86_64|e061ec985562e9b21d75975cb6d60cac3c8874df19e3c6e007d935bc68aaf6b0|29978385",

@jgranstrom jgranstrom Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be best to append the new versions to the default_known_versions rather than replacing the previous default. Especially since it's a pre-release of coursier. That allows a simple one-line revert if it would cause any regressions.

@tdyas tdyas Jul 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Please add the hashes for 2.1.25-M26. Thanks.

"v2.1.24|linux_arm64 |96b4c7580d253b6999a40e94413ca6c4a9bd2339ecce4754ac31a26d1a12fcbf|21534519|https://github.com/VirtusLab/coursier-m1/releases/download/v2.1.24/cs-aarch64-pc-linux.gz",
"v2.1.24|linux_x86_64|d2c0572a17fb6146ea65349b59dd216b38beff60ae22bce6e549867c6ed2eda6|23366878",
"v2.1.24|macos_arm64 |8f47594eb62dea25af913c8932d1f1d86a3a9c8e1262925b63852635390a3f43|21541383|https://github.com/VirtusLab/coursier-m1/releases/download/v2.1.24/cs-aarch64-apple-darwin.gz",
Expand Down
Loading