build(jvm): bump Coursier to v2.1.25-M26 to fix transitive dependenci… - #23517
Open
thiago-carbonera wants to merge 7 commits into
Open
build(jvm): bump Coursier to v2.1.25-M26 to fix transitive dependenci…#23517thiago-carbonera wants to merge 7 commits into
thiago-carbonera wants to merge 7 commits into
Conversation
tobni
reviewed
Jul 10, 2026
tobni
approved these changes
Jul 10, 2026
jgranstrom
reviewed
Jul 10, 2026
jgranstrom
left a comment
jgranstrom
left a comment
Contributor
There was a problem hiding this comment.
Great! It's been quite some time since the last coursier release, so I think it's fair to default to a pre-release to get the fix for transitive dependencies. Just a comment on appending the known versions.
| "v2.1.25-M26|linux_arm64 |68288bcd47a81f3a3bcf0392572d40ec0981172bba9055a8b662413691358be9|30241456|https://github.com/coursier/coursier/releases/download/v2.1.25-M26/cs-aarch64-pc-linux.gz", | ||
| "v2.1.25-M26|linux_x86_64|017812b4da91a72fadd3cb0fb97caae4a16cb947a7bd6be2b46e5aa984458cbf|31136143", | ||
| "v2.1.25-M26|macos_arm64 |4ebc84fa2fd767dffca3b4e63ed1cd7bc0f55870f98f14207e46e00512043bc4|29762912|https://github.com/coursier/coursier/releases/download/v2.1.25-M26/cs-aarch64-apple-darwin.gz", | ||
| "v2.1.25-M26|macos_x86_64|e061ec985562e9b21d75975cb6d60cac3c8874df19e3c6e007d935bc68aaf6b0|29978385", |
Contributor
There was a problem hiding this comment.
It might be best to append the new versions to the default_known_versions rather than replacing the previous default. Especially since it's a pre-release of coursier. That allows a simple one-line revert if it would cause any regressions.
Contributor
There was a problem hiding this comment.
I agree. Please add the hashes for 2.1.25-M26. Thanks.
…es bug Fixes pantsbuild#22909. Updates Coursier default version, hashes, and ARM URLs. Also adjusts expected filename in packaging integration test due to Coursier naming simplification.
…l upstream ARM channel
thiago-carbonera
force-pushed
the
fix-coursier-version
branch
from
July 13, 2026 21:57
79bafc0 to
b522915
Compare
tobni
reviewed
Jul 16, 2026
|
|
||
| The `indicatif-spinner` `dynamic_ui_renderer` (default), now renders on a dedicated thread. This should reduce jitter and display a smoother spinner under heavy load. | ||
|
|
||
| Bumped the default Coursier version to v2.1.25-M26 to fix a bug where transitive dependencies were incorrectly omitted from lockfiles when resolving non-default versions of intermediate dependencies. |
Contributor
There was a problem hiding this comment.
These notes should go under the jvm section I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22909.
Problem
Older versions of Coursier (like
2.1.24) had a bug where transitive dependencies were sometimes omitted from the lockfile if a different version of a dependency was requested (e.g.,timbre -> encore -> trussmissingtrusswhen requesting a non-defaultencoreversion).Solution
v2.1.25-M26, which contains the upstream fix.linux_arm64,linux_x86_64,macos_arm64, andmacos_x86_64.VirtusLabfallback URLs forarm64with the officialcoursier/coursierrelease URLs, as ARM binaries are now officially published.test_resolve_with_packagingincoursier_fetch_integration_test.pyto match the new, simplified jar naming convention from Coursier (removed the redundant_jar_from the expected filename).