Repository navigation
v0.3.0: seven more interop references; template size, connection size and Multiple Service fixes - #7
Merged
Merged
Conversation
… the connection size Found by the new interop peers: - Template attribute 4 is sized so that reading the definition takes words×4 − 23 octets (Logix 5000 Controllers Data Access, 1756-PM020); it was − 21, and pylogix, node-ethernet-ip and libplctag read 2 octets short. The client reads − 23. A Read Template starting at or past the end is refused (pylogix looped on an empty success). - A request on a Class 3 connection carries the connection's reply budget (server.Request.MaxReply); Logix tag replies keep within it with a partial transfer (libplctag on a 504-octet connection got 1228). - A Multiple Service Packet may carry up to 1000 services (was 200; node-ethernet-ip sends about 220 reads in one 4000-octet packet). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A capability-driven suite runs every case a reference declares, against the library's target (adapter, logix and logix-structures fixtures) and, for the references with a target (libplctag's ab_server, gologix), with the library's originator; documented limits of a stack are recorded N/A with their reason. The matrix covers eleven references: 173 pass, 0 fail, 129 N/A against the dev images of ethernetip-interop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…3 pass, 129 N/A Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
× 4 − 23octets (Rockwell 1756-PM020), was− 21; Read Template at/past the end refused (pylogix looped).server.Request.MaxReply); Logix replies keep within it (libplctag on a 504-octet connection got 1228).Test plan
make check(race, lint, coverage 98.6%, examples)🤖 Generated with Claude Code