Skip to content

Bound server replies, I/O lifecycles, scanner intervals, Logix and EDS work - #28

Merged
boeboe merged 1 commit into
mainfrom
fix/server-bounds
Nov 14, 2026
Merged

boeboe merged 1 commit into
mainfrom
fix/server-bounds

Conversation

@boeboe

@boeboe boeboe commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • server:
    • A connection whose TLS handshake fails frees its place under the TCP connection limit.
    • Multiple Service Packet, Get_Attribute_List and Get_Attributes_All stop with 0x11 as soon as the reply exceeds what the packet or the Class 3 connection can carry. Replies that fit are byte-identical.
    • A multicast production starts only while it is still registered and owned.
    • A connection opened during Close is refused.
    • Delayed ListIdentity replies end at Close.
  • implicit: Endpoint.Close also closes produce-only connections.
  • scanner:
    • Open refuses a Forward_Open reply with a T->O actual packet interval of 0, or an O->T interval below a quarter of the requested RPI (and below 100 µs).
    • O->T data goes to the target's address.
  • logix:
    • ListTags and Template are bounded like the fragmented read.
    • BOOL array indices are compared as uint32.
    • Tag sizes are computed without overflow.
    • Read-Modify-Write on an empty member is refused.
  • eds: one entry per resolved number (Param1 / Param01). Validate reports the duplicates and runs in linear time.
  • Docs: SECURITY.md, docs/LIMITATIONS.md, docs/IMPLICIT.md and ARCHITECTURE.md are updated, docs/api is regenerated, and RELEASE.md has a v0.7.0 section.

No exported API changes (gorelease against v0.6.0: compatible).

Test plan

  • make check passes locally (Go 1.27.4): lint, vet, govulncheck, race tests, coverage 99.0 %, docs check.
  • Patch coverage of changed non-test lines is 100 %.
  • 32-bit go vet passes for linux/386 and linux/arm.

🤖 Generated with Claude Code

…S work

- server: a failed TLS handshake frees its connection slot; Multiple
  Service Packet and attribute-list replies stop with 0x11 once they
  exceed the reply budget; a multicast production starts only while it is
  still registered and owned; opening while closing is refused; delayed
  ListIdentity timers end at Close
- implicit: Endpoint.Close also closes produce-only connections
- scanner: check the actual packet intervals of a Forward_Open reply;
  O->T data goes to the target's address
- logix: bound ListTags and Template reads; BOOL array index compared as
  uint32; tag sizes computed without overflow; Read-Modify-Write on empty
  members refused
- eds: one entry per resolved number; Validate uses a keyword index

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@boeboe
boeboe merged commit eec8fda into main Nov 14, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant