Repository navigation
fix(genmatrix): take the references from the results; check the matrix in CI - #26
Merged
Merged
Conversation
…x in CI The matrix generator had its own list of references, without cB-Sigma's enip: its 53 results were missing from INTEROPERABILITY.md and its notes had an empty reference name. The columns now come from interop/results/matrix.json (rows and images); a reference without a display name is an error. A skipped test no longer hides a pass of the same feature in another fixture. make generate-check, which CI runs, now runs genmatrix -check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
internal/cmd/genmatrixno longer has its own list of references: the matrix columns are the references ofinterop/results/matrix.json(rows and images), in the order of the display-name table. A reference without a display name, or with rows but no image, is an error, so a new reference cannot be dropped silently again.cbsigma, display name "cB-Sigma enip") is now in the matrix: 13 reference columns. Its notes had an empty name (**, Class 1 I/O, …) because the generator looked the name up in a map withoutcbsigma; that is the source of the empty bullet, fixed in the generator (the rows in matrix.json are correct).make generate-check(CI job "Generated code") now runsgo run ./internal/cmd/genmatrix -check; it was not enforced before.Evidence
go run ./internal/cmd/genmatrix -checkpasses after regeneration;make generate-checkpasses.go test ./internal/cmd/genmatrix,go vet,staticcheck,golangci-lint runon the package: clean.No library code changes; no release.
🤖 Generated with Claude Code