Skip to content

fix(genmatrix): take the references from the results; check the matrix in CI - #26

Merged
boeboe merged 1 commit into
mainfrom
claude/genmatrix-refs
Nov 12, 2026
Merged

boeboe merged 1 commit into
mainfrom
claude/genmatrix-refs

Conversation

@boeboe

@boeboe boeboe commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

What

  • internal/cmd/genmatrix no longer has its own list of references: the matrix columns are the references of interop/results/matrix.json (rows and images), in the order of the display-name table. A reference without a display name, or with rows but no image, is an error, so a new reference cannot be dropped silently again.
  • cB-Sigma's enip (cbsigma, display name "cB-Sigma enip") is now in the matrix: 13 reference columns. Its notes had an empty name (**, Class 1 I/O, …) because the generator looked the name up in a map without cbsigma; that is the source of the empty bullet, fixed in the generator (the rows in matrix.json are correct).
  • Cell merging: a skipped test (the structures fixture has no scalar tag) no longer overrides a pass of the same feature in another fixture; a failure still outranks a pass. Two cbsigma cells change from "skipped" to ✅; no other cell changes.
  • The summary line now says these are cells and how many test results they come from: 209 passed, 0 failed, 155 not applicable cells, from 383 test results (matrix.json: 221 pass, 160 n/a, 2 skipped results). Before: 181 passed / 142 N/A over 12 columns.
  • make generate-check (CI job "Generated code") now runs go run ./internal/cmd/genmatrix -check; it was not enforced before.
  • Unit tests for the reference derivation.

Evidence

  • go run ./internal/cmd/genmatrix -check passes after regeneration; make generate-check passes.
  • go test ./internal/cmd/genmatrix, go vet, staticcheck, golangci-lint run on the package: clean.

No library code changes; no release.

🤖 Generated with Claude Code

…x in CI

The matrix generator had its own list of references, without cB-Sigma's
enip: its 53 results were missing from INTEROPERABILITY.md and its notes
had an empty reference name. The columns now come from
interop/results/matrix.json (rows and images); a reference without a
display name is an error. A skipped test no longer hides a pass of the
same feature in another fixture. make generate-check, which CI runs,
now runs genmatrix -check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@boeboe
boeboe merged commit f09d18c into main Nov 12, 2026
45 checks passed
@boeboe
boeboe deleted the claude/genmatrix-refs branch November 12, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant