Skip to content

Add CI job building GAP with VALIDATE_MARKING #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fingolfin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CI job building GAP with VALIDATE_MARKING #1420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/gap.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ concurrency:

jobs:
test:
name: Julia ${{ matrix.julia-version }} - GAP ${{ matrix.gap-version }} - ${{ matrix.os }}
name: Julia ${{ matrix.julia-version }} - GAP ${{ matrix.gap-version }} - ${{ matrix.os }}${{ matrix.validate-marking && ' - VALIDATE_MARKING' || '' }}
runs-on: ${{ matrix.os }}
timeout-minutes: 30
continue-on-error: ${{ matrix.julia-version == 'nightly' }}
Expand All @@ -37,6 +37,8 @@ jobs:
- 'nightly'
os:
- ubuntu-latest
validate-marking:
- false
include:
# Add a few macOS jobs (the number we can run in parallel is limited)
- gap-version: 'master'
Expand All @@ -45,6 +47,12 @@ jobs:
- gap-version: 'stable-4.16'
julia-version: '1'
os: macOS-latest
# build the Julia GC integration with VALIDATE_MARKING, to detect
# invalid references during GC marking (see issue #1364)
- gap-version: 'master'
julia-version: '1'
os: ubuntu-latest
validate-marking: true

steps:
- uses: actions/checkout@v7
Expand Down Expand Up @@ -92,7 +100,7 @@ jobs:
make -j`nproc`
- name: "Override bundled GAP"
run: |
julia --project etc/setup_override_dir.jl /tmp/GAPROOT /tmp/gap_jll_override
julia --project etc/setup_override_dir.jl /tmp/GAPROOT /tmp/gap_jll_override ${{ matrix.validate-marking && '--validate-marking' || '' }}
- name: "Run tests"
run: |
julia --project etc/run_with_override.jl /tmp/gap_jll_override --depwarn=error -e "using Pkg; Pkg.test(\"GAP\")"
Expand Down
10 changes: 9 additions & 1 deletion etc/setup_override_dir.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ run_configure = true
overwrite_allow = false
verbose = false
debugmode = false
validate_marking = false
left_ARGS = String[]
while !isempty(ARGS)
arg = popfirst!(ARGS)
Expand All @@ -33,6 +34,8 @@ while !isempty(ARGS)
global verbose = true
elseif arg == "--debug"
global debugmode = true
elseif arg == "--validate-marking"
global validate_marking = true
else
push!(left_ARGS, arg)
end
Expand Down Expand Up @@ -88,7 +91,12 @@ if run_configure

juliabin = joinpath(Sys.BINDIR, Base.julia_exename())

extraargs = ["CPPFLAGS=-DUSE_GAP_INSIDE_JULIA=1"]
cppflags = "-DUSE_GAP_INSIDE_JULIA=1"
if validate_marking
# abort if the GC marking code encounters an invalid reference
cppflags *= " -DVALIDATE_MARKING"
end
extraargs = ["CPPFLAGS=" * cppflags]

if debugmode
# compile GAP in debug mode (enables many additional assertions in the kernel)
Expand Down
Loading