Add CI job building GAP with VALIDATE_MARKING - #1420
Open
fingolfin wants to merge 1 commit into
Open
Conversation
Add a --validate-marking flag to etc/setup_override_dir.jl that compiles the override GAP with -DVALIDATE_MARKING, and a CI job using it against GAP master, so regressions in the GC marking code abort the tests instead of going unnoticed. Needs the fix for the stale validation criteria in GAP's src/julia_gc.c (types of precompiled GAP.jl objects live in the package image, not in a GC pool) to land in GAP master first. See oscar-system#1364. This change was prepared with the assistance of Claude Code. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1420 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 62 62
Lines 5048 5048
Branches 27 27
=======================================
Hits 4207 4207
Misses 841 841 🚀 New features to boost your workflow:
|
fingolfin
marked this pull request as ready for review
August 26, 2026 20:48
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
--validate-markingflag toetc/setup_override_dir.jlthat compiles the override GAP with-DVALIDATE_MARKING, and a job in the "CI with GAP" workflow using it against GAP master, so regressions in the GC marking code abort the tests instead of going unnoticed.The job needs gap-system/gap#6525 (which fixes the stale validation criteria in
src/julia_gc.c) to land in GAP master first; until then it will fail, hence draft.Part of #1364.
AI disclosure: prepared with the assistance of Claude Code.
🤖 Generated with Claude Code