Skip to content

Treat unbound keys as no-op #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkrnr merged 2 commits into from
Jul 23, 2026
Merged

Treat unbound keys as no-op #1855

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4f7a24
Treat unbound key as no-op
toyboot4e Jul 21, 2026
0104f10
Rename, add `.`
toyboot4e Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news.d/bugfix/1850.dict
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Treat unbound keys as no-op

@mkrnr mkrnr Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some trivial points:

  • the file is missing the .md ending
  • I'd rather put it in core instead of dict since it's not modifying the dictionary
  • The text should end with a period

@toyboot4e toyboot4e Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.. I've applied the three points in 0104f10.

2 changes: 1 addition & 1 deletion plover/machine/keymap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def keys_to_actions(self, key_list):
action_list = []
for key in key_list:
assert key in self._keys, "'%s' not in %s" % (key, self._keys)
action = self._bindings[key]
action = self._bindings.get(key, "no-op")
if "no-op" != action:
action_list.append(action)
return action_list
Expand Down
12 changes: 12 additions & 0 deletions test/test_keymap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@ def test_keymap_set_mappings():
assert k.get_mappings() == MAPPINGS_FULL


def test_keymap_keys_to_actions_for_unbound_key():
# An unbound key is treated as no-op.
k = new_keymap()
k.set_bindings(BINDINGS_DICT)
assert "k2" not in k.get_bindings()
assert k.keys_to_actions(["k0", "k2", "k4"]) == ["a0", "a1"]
# If the machine emits a key out of range, it's an error:
with pytest.raises(AssertionError):
# AssertionError: 'k9' not in OrderedDict({...})
k.keys_to_actions(["k9"])


def test_keymap_setitem():
bindings = dict(BINDINGS_DICT)
mappings = dict(MAPPINGS_FULL)
Expand Down
Loading