Treat unbound keys as no-op - #1855
Merged
Merged
Conversation
toyboot4e
force-pushed
the
fix/issue-1850
branch
from
July 21, 2026 11:01
fae5907 to
b4f7a24
Compare
mkrnr
requested changes
Jul 23, 2026
mkrnr
left a comment
mkrnr
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot! I like the approach and it's already a good improvement.
Just some small remarks regarding the news file.
| @@ -0,0 +1 @@ | |||
| Treat unbound keys as no-op | |||
Contributor
There was a problem hiding this comment.
Some trivial points:
- the file is missing the
.mdending - I'd rather put it in
coreinstead ofdictsince it's not modifying the dictionary - The text should end with a period
Contributor
Author
There was a problem hiding this comment.
Thank you.. I've applied the three points in 0104f10.
mkrnr
approved these changes
Jul 23, 2026
Contributor
Author
|
Sorry, it closes #1629, too. It's still open due to my PR comment mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Treat unbound keys as no-op. It's slightly kinder to machine developers.
Closes #1850, #1629
AssertionError: 'k9' not in OrderedDict({...}). Maybe that's ok for now.Pull Request Checklist