Skip to content

Rename mirror-gui product identifier to mirror_gui #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashwindasr merged 1 commit into from
Sep 25, 2026
+3 −3
Merged

Rename mirror-gui product identifier to mirror_gui #3488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion artcommon/artcommonlib/product_ids.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class ProductId(Enum):
MTC = "rhmtc"
OADP = "oadp"
OC_MIRROR = "oc-mirror"
MIRROR_GUI = "mirror-gui"
MIRROR_GUI = "mirror_gui"
RHOSDT = "openshift-opentelemetry-operator"
ZERO_TRUST = "zero-trust-workload-identity-manager"
SUPPLEMENTAL_TOOLS = "supplemental-tools"
Expand Down
2 changes: 1 addition & 1 deletion artcommon/tests/test_product_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def test_installer_is_a_buildable_product(self):

def test_conforma_policy_can_omit_fbc_policy(self):
"""Represent a product with no Conforma FBC policy explicitly."""
config = get_product_config("mirror-gui")
config = get_product_config("mirror_gui")

self.assertEqual(config.conforma_stage_policies.image_policy, "rhtap-releng-tenant/registry-standard")
self.assertIsNone(config.conforma_stage_policies.fbc_policy)
Expand Down
2 changes: 1 addition & 1 deletion artcommon/tests/test_variants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def test_defines_all_product_ids(self):
"oadp": ProductId.OADP,
"quay": ProductId.QUAY,
"oc-mirror": ProductId.OC_MIRROR,
"mirror-gui": ProductId.MIRROR_GUI,
"mirror_gui": ProductId.MIRROR_GUI,
"openshift-opentelemetry-operator": ProductId.RHOSDT,
"zero-trust-workload-identity-manager": ProductId.ZERO_TRUST,
"supplemental-tools": ProductId.SUPPLEMENTAL_TOOLS,
Expand Down
Loading