Rename mirror-gui product identifier to mirror_gui - #3488
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Repository: openshift-eng/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Renames the
mirror-guiproduct identifier tomirror_gui(underscores) to fix the CPE label mismatch in the Konflux release pipeline.Root cause
The
ProductId.MIRROR_GUIvalue was"mirror-gui"(hyphens). During image rebase,rebaser.pyuses this value to construct the CPE label:cpe:/a:redhat:mirror-gui:1.0::el9. The RPA'sprodsec_cpeannotation expects underscores:cpe:/a:redhat:mirror_gui:1::el9. This mismatch causes thestep-check-labelspipeline step to fail.Changes
artcommon/artcommonlib/product_ids.py:MIRROR_GUI = "mirror-gui"→"mirror_gui"artcommon/tests/test_product_registry.py: updated test to use"mirror_gui"artcommon/tests/test_variants.py: updated variant mapping to use"mirror_gui"All 17 tests pass.
A corresponding PR to
openshift-eng/ocp-build-data(branchmirror-gui-1.0) updatesgroup.ymlproductto match.AI-generated. Review for accuracy.
@ashwindasr requested in Slack thread