Skip to content

Rename mirror-gui product identifier to mirror_gui - #3488

Merged
ashwindasr merged 1 commit into
openshift-eng:mainfrom
redhat-chai-bot:fix-mirror-gui-product-name
Sep 25, 2026
Merged

ashwindasr merged 1 commit into
openshift-eng:mainfrom
redhat-chai-bot:fix-mirror-gui-product-name

Conversation

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

Renames the mirror-gui product identifier to mirror_gui (underscores) to fix the CPE label mismatch in the Konflux release pipeline.

Root cause

The ProductId.MIRROR_GUI value was "mirror-gui" (hyphens). During image rebase, rebaser.py uses this value to construct the CPE label: cpe:/a:redhat:mirror-gui:1.0::el9. The RPA's prodsec_cpe annotation expects underscores: cpe:/a:redhat:mirror_gui:1::el9. This mismatch causes the step-check-labels pipeline step to fail.

Changes

  • artcommon/artcommonlib/product_ids.py: MIRROR_GUI = "mirror-gui" → "mirror_gui"
  • artcommon/tests/test_product_registry.py: updated test to use "mirror_gui"
  • artcommon/tests/test_variants.py: updated variant mapping to use "mirror_gui"

All 17 tests pass.

A corresponding PR to openshift-eng/ocp-build-data (branch mirror-gui-1.0) updates group.yml product to match.


AI-generated. Review for accuracy.

@ashwindasr requested in Slack thread

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: openshift-eng/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 98665436-3754-4247-b387-897b0f5dba8c

📥 Commits

Reviewing files that changed from the base of the PR and between 73bfa70 and 74de430.

📒 Files selected for processing (3)
  • artcommon/artcommonlib/product_ids.py
  • artcommon/tests/test_product_registry.py
  • artcommon/tests/test_variants.py

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ashwindasr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashwindasr
ashwindasr merged commit 506f17b into openshift-eng:main Sep 25, 2026
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants