Skip to content

Add NullAway to Alibaba Druid instrumentation #20149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeitlinger wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Add NullAway to Alibaba Druid instrumentation #20149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions instrumentation/alibaba-druid-1.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
plugins {
id("otel.javaagent-instrumentation")
id("otel.nullaway-conventions")
}

muzzle {
Expand Down
3 changes: 2 additions & 1 deletion ...src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import java.util.Map;
import java.util.Properties;
import java.util.logging.Logger;
import javax.annotation.Nullable;

/**
* Parses JDBC connection URLs to extract database connection information.
Expand Down Expand Up @@ -114,7 +115,7 @@ private JdbcConnectionUrlParser() {}
* @return the parsed DbInfo, or DbInfo.DEFAULT for null/invalid non-JDBC inputs; parser failures
* return the best-effort result accumulated before the failure
*/
public static DbInfo parse(String connectionUrl, Properties props) {
public static DbInfo parse(@Nullable String connectionUrl, @Nullable Properties props) {
if (connectionUrl == null) {
return DEFAULT;
}
Expand Down
Loading