Add NullAway to Alibaba Druid instrumentation - #20149
Open
zeitlinger wants to merge 1 commit into
Open
zeitlinger wants to merge 1 commit into
zeitlinger wants to merge 1 commit into
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-14 23:16 UTC Review the latest changes. Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The annotations match existing handling and tests, and the focused rollout introduces no unresolved issues.
Pull request overview
Enables NullAway for Alibaba Druid instrumentation and aligns the shared JDBC parser’s nullability contract with existing behavior.
Changes:
- Enables NullAway conventions for the Druid javaagent module.
- Marks JDBC URL and properties parser inputs nullable.
File summaries
| File | Description |
|---|---|
instrumentation/alibaba-druid-1.0/javaagent/build.gradle.kts |
Enables NullAway checks. |
instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java |
Documents nullable parser inputs. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable
otel.nullaway-conventionsfor the Alibaba Druid 1.0 javaagent instrumentation.Annotate both
JdbcConnectionUrlParser.parseinputs as nullable, matching its documented behavior and existing tests that pass null URLs and properties. This makes the shared internal contract accurately describe the values supplied by Druid and other JDBC integrations.Tests
./gradlew --max-workers=2 :instrumentation:alibaba-druid-1.0:javaagent:check :instrumentation:jdbc:library:checkgit diff --checkmise run lint:fixPart of #15991