Skip to content

test(rename): expose Not_found on incomplete local module #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgrinberg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(rename): expose Not_found on incomplete local module #2033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions ocaml-lsp-server/test/e2e-new/rename.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,31 @@ let%expect_test "prepare rename leaks a lexer error on an astral character" =
|}]
;;

let%expect_test "prepare rename leaks Not_found on an incomplete local module" =
run "let module X" (fun client ->
let* result =
Fiber.collect_errors (fun () ->
prepare_rename client (Position.create ~line:0 ~character:12))
in
match result with
| Error [ { Exn_with_backtrace.exn = Jsonrpc.Response.Error.E error; backtrace = _ } ]
->
Jsonrpc.Response.Error.yojson_of_t error |> censor_backtraces |> Test.print_result;
Fiber.return ()
| Error errors -> Fiber.reraise_all errors
| Ok response ->
print_prepare_rename response;
Fiber.return ());
[%expect
{|
{
"data": { "exn": "Not_found", "backtrace": "<censored>" },
"code": -32603,
"message": "uncaught exception"
}
|}]
;;

let%expect_test "rename returns overlapping edits for an incomplete binding" =
run "let rec ma" (fun client ->
let* response =
Expand Down
Loading