test(rename): expose Not_found on incomplete local module - #2033
Open
rgrinberg wants to merge 1 commit into
Open
test(rename): expose Not_found on incomplete local module#2033rgrinberg wants to merge 1 commit into
rgrinberg wants to merge 1 commit into
Conversation
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-tuqoovrkqsnq
branch
from
July 31, 2026 23:18
3fb44e3 to
aa37295
Compare
Member
Author
|
Seems like a merlin issue @voodoos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for occurrence lookup on the incomplete local-module expression
let module X.textDocument/prepareRenameat the valid EOF position currently leaksNot_foundfromMerlin_analysis.Occurrences.uid_and_loc_of_nodeas JSON-RPCInternalError. The test censors the unstable backtrace and preserves the exception and response code for a test-first fix.