Action Queue Protection and Recovery - #287
Open
Guffawaffle wants to merge 5 commits into
Open
Guffawaffle wants to merge 5 commits into
Guffawaffle wants to merge 5 commits into
Conversation
This was referenced Sep 16, 2026
Guffawaffle
marked this pull request as draft
September 18, 2026 09:27
Contributor
Author
|
This isn't working as well as my previous implementation on my personal branch. Moving back to draft until I figure it out. |
Guffawaffle
marked this pull request as ready for review
September 20, 2026 14:23
Guffawaffle
force-pushed
the
feature/faster-queue-recovery
branch
from
September 24, 2026 02:29
1e4d2bf to
46f144d
Compare
Contributor
Author
|
This is now gloriously effective for me in group waves. |
# Conflicts: # .github/workflows/ci.yaml # xmake.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When another player destroys a queued hostile, native target removal can leave the next target idle. This combines two guarded recovery paths so the queue can continue through the game's existing planner:
Both respect
queue_enabled. The previousadvanced.queue.thin_queue_protectionsetting remains a fallback when the new control key is absent. Recovery rechecks queue identity and state, retains native eligibility checks, and does not force engagement flags or retry counts. There is no new polling loop. The obsolete combat-completion repair remains retired.Hooks are limited to compatible Windows x64 clients; other platforms retain native behavior. The three restored hook sites were checked against the installed client 262 metadata and native function extents.
Validation: Windows release build, both queue-policy suites (including 44 restored protection assertions), all 11 example TOMLs, and diff checks passed. The same recovery code passed live Windows wave testing in the combined downstream build, with both features initialized; the standalone upstream artifact has not been runtime-tested.
The guarded existing class lookup is already in dev through merged #292. Queue storage/layout and planner/watchdog validation remain feature-specific.