-
Notifications
You must be signed in to change notification settings - Fork 255
EDSC-4710: Fixes granules requests with no collection concept id #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
de64a9f
EDSC-4710: Fixes granules requests with no collection concept id
macrouch d40e423
EDSC-4710: npm audit fix
macrouch dbcbb2c
EDSC-4710: Adds comment
macrouch ea807d7
EDSC-4710: Try to fix playwright tests
macrouch 2d3327f
EDSC-4710: Tweak value
macrouch 7d5a184
EDSC-4710: Updates screenshots after blocking tophat from loading in …
macrouch 9c2efd3
EDSC-4710: Updates playwright
macrouch 44477fa
EDSC-4710: Updates screenshots
macrouch 23a6340
EDSC-4710: Switch to arm in github actions
macrouch 12e373b
EDSC-4710: Update device scale factor to match dev machines, retake s…
macrouch 5e062ae
EDSC-4710: Updated chrome screenshots in docker
macrouch 88a343a
EDSC-4710: Removes .only
macrouch 15a867c
EDSC-4710: Switch back to ubuntu-latest
macrouch 62446a4
EDSC-4710: Updates webkit screenshots from actions artifacts, increas…
macrouch dea2470
EDSC-4710: Replace image
macrouch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put this catch further up
if (!collectionId) returnon something like line 49? if the coll is empty do we need to execute anything else on this slice instead bail?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally had it further up but I was looking at what was triggering it, and the bug is because of the opensearch double trigger mentioned in the comments. So I moved it into this
ifstatement. I meant to add details to that comment, I'll do that now